Feat: Add SchemaWrite and SchemaRead implementations for Cell and RefCell
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpthegreat
changed the title
SchemaWrite and SchemaRead implementations for Cell and RefCellSchemaWrite and SchemaRead implementations for Cell and RefCell
cpubot
requested changes
Jan 30, 2026
adpthegreat
force-pushed
the
add_cell_refcell
branch
2 times, most recently
from
566bd51 to
7fa9f7c
Compare
Contributor
Author
|
Done |
cpubot
requested changes
Jan 30, 2026
adpthegreat
force-pushed
the
add_cell_refcell
branch
from
43f8249 to
7cb6852
Compare
cpubot
previously approved these changes
Jan 31, 2026
Contributor
|
It appears some of the tests that were added ballooned the miri test time by an additional ~3 hours. My guess is that it's likely due to some of the complex nested heap allocated types. Should likely limit the length of those data structures in the proptests or remove some of the nesting. |
Contributor
Author
|
i've simplified the nested type and complex type tests |
adpthegreat
force-pushed
the
add_cell_refcell
branch
2 times, most recently
from
90cd29a to
a0a0cb4
Compare
cpubot
requested changes
Feb 3, 2026
- removed unnnecesary trait bounds on SchemaRead and SchemaWrite impls for Cell and RefCell, - removed redundant std feature flags
adpthegreat
force-pushed
the
add_cell_refcell
branch
from
79a0c1c to
a71d459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
SchemaWriteandSchemaReadimplementations of theCellandRefCelltypes instd::cellPorting the types from the bincode impls here
Didn't implement ZeroCopy for Cell because we can't guarantee whether
Tcan be safely constructed from bytes