Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-38 List providers #45535

Merged
merged 4 commits into from
Jan 31, 2025
Merged

AIP-38 List providers #45535

merged 4 commits into from
Jan 31, 2025

Conversation

dauinh
Copy link
Contributor

@dauinh dauinh commented Jan 10, 2025

related: #43708

Screenshot 2025-01-09 at 4 45 15 PM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 10, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Just a few nit / suggestions.

@bbovenzi
Copy link
Contributor

Could you run pnpm lint && pnpm format locally? Looks like static checks are failing.

@dauinh
Copy link
Contributor Author

dauinh commented Jan 24, 2025

I just did! Thank you for your reviews! I simplified the code by changing the URL into a link component. I couldn't figure out how to work with replace or other JS functions, so I kept embedLinks. If you have any suggestion, please let me know.

I couldn't reproduce the key prop error either, but I did have key prop for each table row. I hope that works!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you rebase the branch. I would like to test the branch locally but I am experiencing some conflicts on main. :)

@pierrejeambrun pierrejeambrun added the AIP-38 Modern Web Application label Jan 29, 2025
@pierrejeambrun pierrejeambrun added this to the Airflow 3.0.0 milestone Jan 29, 2025
@pierrejeambrun pierrejeambrun changed the title List providers AIP-38 List providers Jan 29, 2025
@dauinh
Copy link
Contributor Author

dauinh commented Jan 29, 2025

I have rebased my branch to the most updated main branch. Thank you for your time and guidance!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

Just one small question.

@pierrejeambrun pierrejeambrun merged commit 9ef89ac into apache:main Jan 31, 2025
35 checks passed
Prab-27 pushed a commit to Prab-27/airflow that referenced this pull request Jan 31, 2025
* rebasing

* fix regex

* remove pnpm from package.json
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* rebasing

* fix regex

* remove pnpm from package.json
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* rebasing

* fix regex

* remove pnpm from package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-38 Modern Web Application area:UI Related to UI/UX. For Frontend Developers.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants