-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-38 List providers #45535
AIP-38 List providers #45535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Just a few nit / suggestions.
Could you run |
I just did! Thank you for your reviews! I simplified the code by changing the URL into a link component. I couldn't figure out how to work with I couldn't reproduce the key prop error either, but I did have key prop for each table row. I hope that works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, can you rebase the branch. I would like to test the branch locally but I am experiencing some conflicts on main. :)
ab4daf1
to
4b18056
Compare
I have rebased my branch to the most updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks.
Just one small question.
* rebasing * fix regex * remove pnpm from package.json
* rebasing * fix regex * remove pnpm from package.json
* rebasing * fix regex * remove pnpm from package.json
related: #43708
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.