Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dag filtering in home page and dag documentation modal #45607

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

tirkarthi
Copy link
Contributor

This adds basic tests to ensure filter buttons in dags list page works. This also adds tests for dag documentation button and modal opening flow on click.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 13, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice.

Thanks for introducing the mock server.

Just a few nit/suggestions.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit.

Looks good, thanks.

Branch needs rebasing.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can improve our Wrappers in another PR

@bbovenzi
Copy link
Contributor

But it looks like we need a rebase

@tirkarthi
Copy link
Contributor Author

Rebased against main which had changes to markdown rendering components.

@pierrejeambrun pierrejeambrun merged commit 1353ad4 into apache:main Jan 24, 2025
35 checks passed
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Jan 27, 2025
@utkarsharma2 utkarsharma2 added this to the Airflow 3.0.0 milestone Jan 27, 2025
gpathak128 pushed a commit to gpathak128/airflow that referenced this pull request Jan 29, 2025
…pache#45607)

* Add tests for dags list page filter and dag documentation button.

* Reorganize handlers to separate mock directory for reuse.

* Rename test data to avoid laptop file paths.

* Refactor mock setup and wrapper.

* Rebase and fix conflicts.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…pache#45607)

* Add tests for dags list page filter and dag documentation button.

* Reorganize handlers to separate mock directory for reuse.

* Rename test data to avoid laptop file paths.

* Refactor mock setup and wrapper.

* Rebase and fix conflicts.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
…pache#45607)

* Add tests for dags list page filter and dag documentation button.

* Reorganize handlers to separate mock directory for reuse.

* Rename test data to avoid laptop file paths.

* Refactor mock setup and wrapper.

* Rebase and fix conflicts.
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…pache#45607)

* Add tests for dags list page filter and dag documentation button.

* Reorganize handlers to separate mock directory for reuse.

* Rename test data to avoid laptop file paths.

* Refactor mock setup and wrapper.

* Rebase and fix conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants