-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for dag filtering in home page and dag documentation modal #45607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice.
Thanks for introducing the mock server.
Just a few nit/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non blocking nit.
Looks good, thanks.
Branch needs rebasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can improve our Wrappers in another PR
But it looks like we need a rebase |
Rebased against main which had changes to markdown rendering components. |
…pache#45607) * Add tests for dags list page filter and dag documentation button. * Reorganize handlers to separate mock directory for reuse. * Rename test data to avoid laptop file paths. * Refactor mock setup and wrapper. * Rebase and fix conflicts.
…pache#45607) * Add tests for dags list page filter and dag documentation button. * Reorganize handlers to separate mock directory for reuse. * Rename test data to avoid laptop file paths. * Refactor mock setup and wrapper. * Rebase and fix conflicts.
…pache#45607) * Add tests for dags list page filter and dag documentation button. * Reorganize handlers to separate mock directory for reuse. * Rename test data to avoid laptop file paths. * Refactor mock setup and wrapper. * Rebase and fix conflicts.
…pache#45607) * Add tests for dags list page filter and dag documentation button. * Reorganize handlers to separate mock directory for reuse. * Rename test data to avoid laptop file paths. * Refactor mock setup and wrapper. * Rebase and fix conflicts.
This adds basic tests to ensure filter buttons in dags list page works. This also adds tests for dag documentation button and modal opening flow on click.
initialEntries
to load the tests in a given URL location for assertion. There were some issues in using existingWrapper.tsx
with the changes in existing tests so created usingAppWrapper.tsx
with the changes to keep them separate.