Handle Hybrid executors for running task logs #45971
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Hybrid executors where one of them is a Kubernetes-based executor (but not the first one) breaks live logs since we only try to fetch k8s pods logs if the default executor happens to be the Kubernetes executor. This PR fixes it.
Note: it's my first PR and I probably don't have time to set up the whole testing environment. If you consider this change requires thorough testing please FFT to close this and revisit at a further date (just wanted to flag this)