Skip to content

feat(install): auto set the default time zone to where the server is located #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

hgaol
Copy link
Member

@hgaol hgaol commented Apr 2, 2025

Close #1303

@LinkinStars LinkinStars self-requested a review April 2, 2025 14:31
@LinkinStars LinkinStars self-assigned this Apr 2, 2025
Copy link
Member

@LinkinStars LinkinStars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long review. I've been looking for a way to do this without enumerating all the timezone constants, but haven't found a more elegant solution yet. I'll merge this PR for now and if there's a better way I'll do a replacement.

@LinkinStars LinkinStars merged commit 840f6bf into apache:dev Apr 11, 2025
@hgaol
Copy link
Member Author

hgaol commented Apr 11, 2025

No worries, feel free to refactor! I also tried but not found. I think it may because many locations will share the same time offset, if we depends on time offset, we don't know the exact location. If it can get the geo location instead of time offset, maybe can find a better approach.

@hgaol hgaol deleted the 1303 branch April 13, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants