Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changs for Bug: https://github.com/apache/apisix-java-plugin-runner/i… #256

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Changs for Bug: https://github.com/apache/apisix-java-plugin-runner/i… #256

wants to merge 7 commits into from

Conversation

abhi0476
Copy link

@abhi0476 abhi0476 commented Jul 14, 2023 •
edited
Loading

…ssues/254

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Related issues

Bugfix

  • Description

  • How to fix?

New feature or improvement

  • Describe the details and related test reports.

  • Source branch

  • Related commits and pull requests

  • Target branch

@Sn0rt
Copy link

Sn0rt commented Jul 17, 2023

@tao12345666333 pls hele us to review this PR thx

@Sn0rt
Copy link

Sn0rt commented Jul 17, 2023

#254

@tao12345666333
Copy link
Member

Maybe @soulbird can help you

@soulbird
Copy link

Need to add test case

@abhi0476
Copy link
Author

Need to add test case

Fixed test cases

@leslie-tsang leslie-tsang requested a review from soulbird July 21, 2023 01:06
@abhi0476
Copy link
Author

Will you please fix this bug yourself as I dont have further time for development

@Sn0rt
Copy link

Sn0rt commented Jul 31, 2023

Will you please fix this bug yourself as I dont have further time for development

hi. can you take a look the CI ?

@yuluo-yx
Copy link
Member

yuluo-yx commented Aug 9, 2023

Please assign it to me and I will get it done!

@abhi0476
Copy link
Author

abhi0476 commented Aug 9, 2023

Fixed some CI/CD issues

yuluo-yx
yuluo-yx approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@yuluo-yx yuluo-yx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @abhi0476

@yuluo-yx
Copy link
Member

yuluo-yx commented Aug 11, 2023 •
edited
Loading

@abhi0476 Please refer to the ci error content to modify the problem in the code. In addition, you can run the mvn clean install -Dgpg.skip=trueH command locally and submit the code after confirming that it passes the mvn check.

@yuluo-yx
Copy link
Member

@abhi0476 hi, are you still following up on this PR?

@abhi0476
Copy link
Author

@abhi0476 hi, are you still following up on this PR?

Yes fixed the CI

@Revolyssup
Copy link

@abhi0476 The CI is still failing. PTAL

@joyyir
Copy link
Contributor

joyyir commented Jan 3, 2024

@abhi0476 Please check the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuluo-yx yuluo-yx yuluo-yx approved these changes

@soulbird soulbird Awaiting requested review from soulbird

At least 1 approving review is required to merge this pull request.

Assignees

@yuluo-yx yuluo-yx

Labels
None yet
Projects
Apache APISIX backlog
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@abhi0476 @Sn0rt @tao12345666333 @soulbird @yuluo-yx @Revolyssup @joyyir