Skip to content

Conversation

@ajhlee-dbt
Copy link
Contributor

Added an option to wrap query errors on Bigquery with a link to the failing query job. This is configurable via "adbc.bigquery.sql.query.link_failed_job".

@ajhlee-dbt ajhlee-dbt requested a review from zeroshade as a code owner October 23, 2025 22:41
@github-actions github-actions bot added this to the ADBC Libraries 21 milestone Oct 23, 2025
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to make this an option vs just always including it in the error?

@felipecrv
Copy link
Contributor

Is there any reason to make this an option vs just always including it in the error?

Verbosity of the error message.

@lidavidm
Copy link
Member

Is it that much? I personally detest having to hunt for the "give me the real error" knob

@zeroshade
Copy link
Member

Could we just always put it into the ErrorDetails? That way the full error is still there but the user can decide if they want it in the output or not

@lidavidm
Copy link
Member

My one concern with ErrorDetails is then the vendor code can't be read, but (1) hopefully we fix that soon with an API revision (2) maybe BigQuery doesn't use that anyways?

@zeroshade
Copy link
Member

@lidavidm looking at the bigquery docs, it doesn't look like the error messages include a vendor code, so I don't think it's an issue to use the ErrorDetails etc.

@zeroshade
Copy link
Member

@felipecrv thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants