Allow explicitly specifying GCS base URL #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgehan
changed the title
tustvold
reviewed
Dec 12, 2025
Contributor
Author
|
@tustvold I've added a configuration key, and fixed lint/doc issues. Let me know if there's anything else I can do! |
kylebarron
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #566
Rationale for this change
Currently, the only way to override the GCS base URL is to provide a service account credentials file that contains a
gcs_base_url.If for some reason the user cannot provide such a file (because they're authenticated a different way), being able to explicitly override the base URL is useful.
This can also be useful while testing locally, against a local implementation of GCS (I'm not personally doing this, but I suppose this is a valid use case)
What changes are included in this PR?
This PR adds a
.with_base_url()method on the GCP builder, accompanied with unit tests.This override takes precedence over the URL from the service account credentials file, but is optional, so this should be strictly compatible with the previous implementation.
Are there any user-facing changes?
New
.with_base_url()on the GCS builder.No breaking changes.