-
Notifications
You must be signed in to change notification settings - Fork 118
fix: docs.rs build failure
#591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See https://docs.rs/crate/object_store/latest/builds/2752265 : ```text [INFO] [stderr] Documenting object_store v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] error[E0557]: feature has been removed [INFO] [stderr] --> src/lib.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] [INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed [INFO] [stderr] | [INFO] [stderr] = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information [INFO] [stderr] = note: merged into `doc_cfg` [INFO] [stderr] [INFO] [stderr] error: Compilation failed, aborting rustdoc [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0557`. [INFO] [stderr] error: could not document `object_store` ```
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @crepererum
I think we should make a 0.13.1 patch release (as having no docs is pretty serious in my mind). I'll file a ticket later today or tomorrow to track that process if no one beats me to it
|
Clippy failure should be fixed by #592 so I am rerunning CI |
|
I am proposing a new release to include this fix: |
See https://docs.rs/crate/object_store/latest/builds/2752265 : ```text [INFO] [stderr] Documenting object_store v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] error[E0557]: feature has been removed [INFO] [stderr] --> src/lib.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] [INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed [INFO] [stderr] | [INFO] [stderr] = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information [INFO] [stderr] = note: merged into `doc_cfg` [INFO] [stderr] [INFO] [stderr] error: Compilation failed, aborting rustdoc [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0557`. [INFO] [stderr] error: could not document `object_store` ``` Co-authored-by: Andrew Lamb <[email protected]>
See https://docs.rs/crate/object_store/latest/builds/2752265 : ```text [INFO] [stderr] Documenting object_store v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] error[E0557]: feature has been removed [INFO] [stderr] --> src/lib.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] [INFO] [stderr] | ^^^^^^^^^^^^ feature has been removed [INFO] [stderr] | [INFO] [stderr] = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information [INFO] [stderr] = note: merged into `doc_cfg` [INFO] [stderr] [INFO] [stderr] error: Compilation failed, aborting rustdoc [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0557`. [INFO] [stderr] error: could not document `object_store` ``` Co-authored-by: Marco Neumann <[email protected]>
Which issue does this PR close?
Rationale for this change
https://docs.rs/crate/object_store/latest is broken:
See https://docs.rs/crate/object_store/latest/builds/2752265 :
What changes are included in this PR?
Fix for feature flag.
Are there any user-facing changes?
Docs may build again with next release.