Skip to content

Conversation

@crepererum
Copy link
Contributor

@crepererum crepererum commented Jan 5, 2026

Which issue does this PR close?

Rationale for this change

https://docs.rs/crate/object_store/latest is broken:

Screenshot 2026-01-08 at 4 38 40 PM

See https://docs.rs/crate/object_store/latest/builds/2752265 :

[INFO] [stderr]  Documenting object_store v0.13.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0557]: feature has been removed
[INFO] [stderr]   --> src/lib.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
[INFO] [stderr]    |                             ^^^^^^^^^^^^ feature has been removed
[INFO] [stderr]    |
[INFO] [stderr]    = note: removed in 1.92.0; see <https://github.com/rust-lang/rust/pull/138907> for more information
[INFO] [stderr]    = note: merged into `doc_cfg`
[INFO] [stderr]
[INFO] [stderr] error: Compilation failed, aborting rustdoc
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0557`.
[INFO] [stderr] error: could not document `object_store`

What changes are included in this PR?

Fix for feature flag.

Are there any user-facing changes?

Docs may build again with next release.

See https://docs.rs/crate/object_store/latest/builds/2752265 :

```text
[INFO] [stderr]  Documenting object_store v0.13.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0557]: feature has been removed
[INFO] [stderr]   --> src/lib.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
[INFO] [stderr]    |                             ^^^^^^^^^^^^ feature has been removed
[INFO] [stderr]    |
[INFO] [stderr]    = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information
[INFO] [stderr]    = note: merged into `doc_cfg`
[INFO] [stderr]
[INFO] [stderr] error: Compilation failed, aborting rustdoc
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0557`.
[INFO] [stderr] error: could not document `object_store`
```
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crepererum

I think we should make a 0.13.1 patch release (as having no docs is pretty serious in my mind). I'll file a ticket later today or tomorrow to track that process if no one beats me to it

@alamb
Copy link
Contributor

alamb commented Jan 5, 2026

Clippy failure should be fixed by #592 so I am rerunning CI

@crepererum crepererum merged commit 5cb565b into apache:main Jan 5, 2026
8 checks passed
@alamb
Copy link
Contributor

alamb commented Jan 8, 2026

I am proposing a new release to include this fix:

alamb added a commit to alamb/arrow-rs-object-store that referenced this pull request Jan 8, 2026
See https://docs.rs/crate/object_store/latest/builds/2752265 :

```text
[INFO] [stderr]  Documenting object_store v0.13.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0557]: feature has been removed
[INFO] [stderr]   --> src/lib.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
[INFO] [stderr]    |                             ^^^^^^^^^^^^ feature has been removed
[INFO] [stderr]    |
[INFO] [stderr]    = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information
[INFO] [stderr]    = note: merged into `doc_cfg`
[INFO] [stderr]
[INFO] [stderr] error: Compilation failed, aborting rustdoc
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0557`.
[INFO] [stderr] error: could not document `object_store`
```

Co-authored-by: Andrew Lamb <[email protected]>
alamb added a commit that referenced this pull request Jan 9, 2026
See https://docs.rs/crate/object_store/latest/builds/2752265 :

```text
[INFO] [stderr]  Documenting object_store v0.13.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0557]: feature has been removed
[INFO] [stderr]   --> src/lib.rs:18:29
[INFO] [stderr]    |
[INFO] [stderr] 18 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
[INFO] [stderr]    |                             ^^^^^^^^^^^^ feature has been removed
[INFO] [stderr]    |
[INFO] [stderr]    = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information
[INFO] [stderr]    = note: merged into `doc_cfg`
[INFO] [stderr]
[INFO] [stderr] error: Compilation failed, aborting rustdoc
[INFO] [stderr]
[INFO] [stderr] For more information about this error, try `rustc --explain E0557`.
[INFO] [stderr] error: could not document `object_store`
```

Co-authored-by: Marco Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants