[release/0.12] Fix new CI issues #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
changed the title
AdamGS
force-pushed
the
adamg/make-0-12-ci-green
branch
from
4d0cc57 to
4abf126
Compare
AdamGS
commented
Jan 8, 2026
| # Necessary because tokio 1.30.0 updates MSRV to 1.63 | ||
| # and url 2.5.1, updates to 1.67 | ||
| run: | | ||
| cargo update -p parking_lot --precise 0.12.4 |
Contributor
Author
There was a problem hiding this comment.
A lot of crates just recently made the jump from 1.64 to 1.68, parking_lot and tokio moved to 1.71 and even tracing made a very significant change to 1.65.
AdamGS
commented
Jan 8, 2026
Comment on lines
+847
to
849
| // TcpStream::set_linger is deprecated but this use case is valid to reset the stream | ||
| #[allow(deprecated)] | ||
| stream.set_linger(Some(Duration::from_secs(0))).unwrap(); |
Contributor
Author
There was a problem hiding this comment.
My understanding is that this is more about it being a potential performance issue than anything else, with the thread being potentially blocked on drop.
This specific options will also be now available in new tokio versions as TcpStream::et_linger_zero.
Contributor
There was a problem hiding this comment.
Indeed -- @crepererum fixed the same issue in basically the same way on main in
alamb
changed the title
alamb
approved these changes
Jan 8, 2026
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.12.5(maintenance) - Target Dec 2025 #582This PR fixes some issues that have crept into this branch since the last minor release.