Review feedback

apache · Feb 16, 2025 · 7872490 · 7872490
1 parent 0174fec
commit 7872490
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/parquet/src/arrow/async_reader/metadata.rs b/parquet/src/arrow/async_reader/metadata.rs
@@ -131,7 +131,7 @@ impl<F: MetadataFetch> MetadataLoader<F> {
             (
                 ParquetMetaDataReader::decode_metadata(
                     &meta,
-                    footer.encrypted_footer(),
+                    footer.is_encrypted_footer(),
                     #[cfg(feature = "encryption")]
                     None,
                 )?,
@@ -144,7 +144,7 @@ impl<F: MetadataFetch> MetadataLoader<F> {
             (
                 ParquetMetaDataReader::decode_metadata(
                     slice,
-                    footer.encrypted_footer(),
+                    footer.is_encrypted_footer(),
                     #[cfg(feature = "encryption")]
                     None,
                 )?,

diff --git a/parquet/src/arrow/async_reader/mod.rs b/parquet/src/arrow/async_reader/mod.rs
@@ -179,7 +179,7 @@ impl<T: AsyncRead + AsyncSeek + Unpin + Send> AsyncFileReader for T {
 
             Ok(Arc::new(ParquetMetaDataReader::decode_metadata(
                 &buf,
-                footer.encrypted_footer(),
+                footer.is_encrypted_footer(),
                 #[cfg(feature = "encryption")]
                 file_decryption_properties,
             )?))

diff --git a/parquet/src/file/metadata/reader.rs b/parquet/src/file/metadata/reader.rs
@@ -95,7 +95,7 @@ impl FooterTail {
     }
 
     /// Whether the footer metadata is encrypted
-    pub fn encrypted_footer(&self) -> bool {
+    pub fn is_encrypted_footer(&self) -> bool {
         self.encrypted_footer
     }
 }
@@ -568,7 +568,7 @@ impl ParquetMetaDataReader {
         let start = file_size - footer_metadata_len as u64;
         Self::decode_metadata(
             chunk_reader.get_bytes(start, metadata_len)?.as_ref(),
-            footer.encrypted_footer(),
+            footer.is_encrypted_footer(),
             #[cfg(feature = "encryption")]
             self.file_decryption_properties.as_ref(),
         )
@@ -637,7 +637,7 @@ impl ParquetMetaDataReader {
             Ok((
                 Self::decode_metadata(
                     &meta,
-                    footer.encrypted_footer(),
+                    footer.is_encrypted_footer(),
                     #[cfg(feature = "encryption")]
                     file_decryption_properties,
                 )?,
@@ -649,7 +649,7 @@ impl ParquetMetaDataReader {
             Ok((
                 Self::decode_metadata(
                     slice,
-                    footer.encrypted_footer(),
+                    footer.is_encrypted_footer(),
                     #[cfg(feature = "encryption")]
                     file_decryption_properties,
                 )?,