Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rok committed Feb 17, 2025
1 parent 815e35d commit d3df0ab
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions parquet/src/arrow/async_reader/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl<F: MetadataFetch> MetadataLoader<F> {
(
ParquetMetaDataReader::decode_metadata(
&meta,
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
None,
)?,
Expand All @@ -144,7 +144,7 @@ impl<F: MetadataFetch> MetadataLoader<F> {
(
ParquetMetaDataReader::decode_metadata(
slice,
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
None,
)?,
Expand Down
2 changes: 1 addition & 1 deletion parquet/src/arrow/async_reader/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ impl<T: AsyncRead + AsyncSeek + Unpin + Send> AsyncFileReader for T {

Ok(Arc::new(ParquetMetaDataReader::decode_metadata(
&buf,
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
file_decryption_properties,
)?))
Expand Down
8 changes: 4 additions & 4 deletions parquet/src/file/metadata/reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ impl FooterTail {
}

/// Whether the footer metadata is encrypted
pub fn encrypted_footer(&self) -> bool {
pub fn is_encrypted_footer(&self) -> bool {
self.encrypted_footer
}
}
Expand Down Expand Up @@ -570,7 +570,7 @@ impl ParquetMetaDataReader {
let start = file_size - footer_metadata_len as u64;
Self::decode_metadata(
chunk_reader.get_bytes(start, metadata_len)?.as_ref(),
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
self.file_decryption_properties.as_ref(),
)
Expand Down Expand Up @@ -639,7 +639,7 @@ impl ParquetMetaDataReader {
Ok((
Self::decode_metadata(
&meta,
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
file_decryption_properties,
)?,
Expand All @@ -651,7 +651,7 @@ impl ParquetMetaDataReader {
Ok((
Self::decode_metadata(
slice,
footer.encrypted_footer(),
footer.is_encrypted_footer(),
#[cfg(feature = "encryption")]
file_decryption_properties,
)?,
Expand Down

0 comments on commit d3df0ab

Please sign in to comment.