Skip to content

Add content length to GCP multipart complete #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkosh44 wants to merge 2 commits into from
Closed

Add content length to GCP multipart complete #7301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab06852
Add content length to GCP multipart complete
jkosh44 Mar 17, 2025
9db5923
Remove content length form multipart-complete
jkosh44 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions object_store/src/gcp/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ impl GoogleCloudStorageClient {
// GCS doesn't allow empty multipart uploads
Copy link
Contributor

@tustvold tustvold Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could perhaps make this more clear by simply calling self.put directly

Copy link
Author

@jkosh44 jkosh44 Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but self.put also doesn't set Content-length so we'd have the same issue. I could update self.put to always set the Content-Length if the payload is empty. That would have a larger blast radius though. Thoughts?

let result = self
.request(Method::PUT, path)
.header(&CONTENT_LENGTH, "0")
.idempotent(true)
.do_put()
.await?;
Expand All @@ -540,6 +541,7 @@ impl GoogleCloudStorageClient {
let response = self
.client
.request(Method::POST, &url)
.header(&CONTENT_LENGTH, data.len())
Copy link
Contributor

@tustvold tustvold Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be unnecessary, and I believe is potentially incorrect if the client decides to use a some sort of transport encoding

Copy link
Author

@jkosh44 jkosh44 Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

.bearer_auth(&credential.bearer)
.query(&[("uploadId", upload_id)])
.body(data)
Expand Down
Loading