Parquet: change default type for parquet v2 from delta to delta-length-byte-array #8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should discuss this one in an issue. I know the spec says delta_length_byte_array is the default fallback, but I think delta_byte_array is used by parquet-java (I'll admit to not having looked at this for several years). I'm mildly in favor of this change, but others might have different opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Previously, v2 uses "delta" to encoding values, however it's too expansive for non-delta. Can we shift it to delta length byte array?
Rationale for this change
Change the parquet-v2 default encoding to delta-length-byte-array
What changes are included in this PR?
Change the parquet-v2 default encoding to delta-length-byte-array
Are these changes tested?
Covered by existing
Are there any user-facing changes?
No