Skip to content

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jun 4, 2025

Rationale for this change

The new version of auditwheel has added improvements to detect libc / platform on the wheels:

This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order.

What changes are included in this PR?

Force the newest version and update to new order of platform tags.

Are these changes tested?

Via archery.

Are there any user-facing changes?

No

…ame generated from latest auditwheel version
Copy link

github-actions bot commented Jun 4, 2025

⚠️ GitHub issue #46691 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 4, 2025
@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-cp313-cp313-*

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-*

@raulcd raulcd changed the title GH-46691: [CI][Packaging] Reorder platform tag to match wheel name generated from latest auditwheel version GH-46691: [CI][Packaging] Make order of platform tag on generated wheel name not relevant for uploaded artifact validation Jun 4, 2025
Copy link

github-actions bot commented Jun 4, 2025

Revision: afdf276

Submitted crossbow builds: ursacomputing/crossbow @ actions-5a36b43cc0

Task Status
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64

This comment was marked as outdated.

@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64

Copy link

github-actions bot commented Jun 4, 2025

Revision: 4caab32

Submitted crossbow builds: ursacomputing/crossbow @ actions-351a7828b5

Task Status
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jun 4, 2025

@github-actions crossbow submit wheel-manylinux-2014-*

Copy link

github-actions bot commented Jun 4, 2025

Revision: 4caab32

Submitted crossbow builds: ursacomputing/crossbow @ actions-3fe8019705

Task Status
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions

@raulcd raulcd marked this pull request as ready for review June 4, 2025 13:03
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. If we run dev/release/verify-release-candidate.sh with Python 3.13 without TEST_WHEEL_PLATFORM_TAGS on local for the next release vote, it'll be failed because manylinux2014_${arch}.manylinux_2_17_${arch} not manylinux_2_17_${arch}.manylinux2014_${arch} is used, right?

Do we have more stable(?) approach? (Should we improve auditwheel?)

continue
fi
pip install pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \
ls pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 4, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 5, 2025
@raulcd
Copy link
Member Author

raulcd commented Jun 5, 2025

@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64 wheel-manylinux-2014-cp313-cp313-amd64

Copy link

github-actions bot commented Jun 5, 2025

Revision: cc7facb

Submitted crossbow builds: ursacomputing/crossbow @ actions-f191869fad

Task Status
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jun 5, 2025

@github-actions crossbow submit wheel-manylinux-2014-*

Copy link

github-actions bot commented Jun 5, 2025

Revision: cc7facb

Submitted crossbow builds: ursacomputing/crossbow @ actions-e546bc5ba4

Task Status
wheel-manylinux-2014-cp310-cp310-amd64 GitHub Actions
wheel-manylinux-2014-cp310-cp310-arm64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-amd64 GitHub Actions
wheel-manylinux-2014-cp311-cp311-arm64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-amd64 GitHub Actions
wheel-manylinux-2014-cp312-cp312-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313-arm64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-amd64 GitHub Actions
wheel-manylinux-2014-cp313-cp313t-arm64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-amd64 GitHub Actions
wheel-manylinux-2014-cp39-cp39-arm64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jun 5, 2025

Do we have more stable(?) approach? (Should we improve auditwheel?)

It seems forcing the jobs to use the latest version of auditwheel is stable with the new ordering. Let's wait for CI to finish but that seems better than the regex.

@raulcd raulcd changed the title GH-46691: [CI][Packaging] Make order of platform tag on generated wheel name not relevant for uploaded artifact validation GH-46691: [CI][Packaging] Update platform tag on generated wheel name to match newest auditwheel naming Jun 5, 2025
@raulcd raulcd requested a review from kou June 5, 2025 09:03
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 3d4e8bc into apache:main Jun 5, 2025
38 of 43 checks passed
@kou kou removed the awaiting change review Awaiting change review label Jun 5, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 5, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3d4e8bc.

There were 68 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
…l name to match newest auditwheel naming (apache#46705)

### Rationale for this change

The new version of auditwheel has added improvements to detect libc / platform on the wheels:
- pypa/auditwheel#548

This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order.

### What changes are included in this PR?

Force the newest version and update to new order of platform tags.

### Are these changes tested?

Via archery.

### Are there any user-facing changes?

No

* GitHub Issue: apache#46691

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants