-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-46691: [CI][Packaging] Update platform tag on generated wheel name to match newest auditwheel naming #46705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ame generated from latest auditwheel version
|
@github-actions crossbow submit wheel-manylinux-2014-cp313-cp313-* |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-manylinux-2014-* |
Revision: afdf276 Submitted crossbow builds: ursacomputing/crossbow @ actions-5a36b43cc0 |
@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64 |
Revision: 4caab32 Submitted crossbow builds: ursacomputing/crossbow @ actions-351a7828b5
|
@github-actions crossbow submit wheel-manylinux-2014-* |
Revision: 4caab32 Submitted crossbow builds: ursacomputing/crossbow @ actions-3fe8019705 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. If we run dev/release/verify-release-candidate.sh
with Python 3.13 without TEST_WHEEL_PLATFORM_TAGS
on local for the next release vote, it'll be failed because manylinux2014_${arch}.manylinux_2_17_${arch}
not manylinux_2_17_${arch}.manylinux2014_${arch}
is used, right?
Do we have more stable(?) approach? (Should we improve auditwheel?)
continue | ||
fi | ||
pip install pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-${platform}.whl | ||
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find . -name pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \ | |
ls pyarrow-${TEST_PYARROW_VERSION:-${VERSION}}-cp${pyver/.}-cp${python/.}-*.whl | grep -E "${platform}" | \ |
…on newer auditwheel
@github-actions crossbow submit wheel-manylinux-2014-cp310-cp310-amd64 wheel-manylinux-2014-cp313-cp313-amd64 |
Revision: cc7facb Submitted crossbow builds: ursacomputing/crossbow @ actions-f191869fad
|
@github-actions crossbow submit wheel-manylinux-2014-* |
Revision: cc7facb Submitted crossbow builds: ursacomputing/crossbow @ actions-e546bc5ba4 |
It seems forcing the jobs to use the latest version of auditwheel is stable with the new ordering. Let's wait for CI to finish but that seems better than the regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3d4e8bc. There were 68 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…l name to match newest auditwheel naming (apache#46705) ### Rationale for this change The new version of auditwheel has added improvements to detect libc / platform on the wheels: - pypa/auditwheel#548 This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order. ### What changes are included in this PR? Force the newest version and update to new order of platform tags. ### Are these changes tested? Via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#46691 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
The new version of auditwheel has added improvements to detect libc / platform on the wheels:
This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order.
What changes are included in this PR?
Force the newest version and update to new order of platform tags.
Are these changes tested?
Via archery.
Are there any user-facing changes?
No
wheel-manylinux-2014-cp313
#46691