GH-47552: [C++] Fix creating wrong object by FixedShapeTensorType::MakeArray()
#47533
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
changed the title
FixedShapeTensorType::MakeArray()
|
|
Cool |
corpoverlords
changed the title
FixedShapeTensorType::MakeArray()FixedShapeTensorType::MakeArray()
|
|
corpoverlords
force-pushed
the
fjiang/fixed_upstreaming
branch
from
9abd336 to
de92aac
Compare
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7548c3d. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The builder should return the correct type.
What changes are included in this PR?
One liner
Are these changes tested?
Yes
Are there any user-facing changes?
No