Skip to content

Issue #252: Add an Option<String> field with a #[avro(default = "null")] #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Issue #252: Add an Option<String> field with a #[avro(default = "null")] #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86ad0d0
Issue #252: Add an `Option<String>` field with a `#[avro(default = "n…
martin-g Aug 12, 2025
ed76f61
Use non-raw string
martin-g Aug 12, 2025
5b01631
Fix the default value for an union schema
martin-g Aug 12, 2025
5139d6c
Fix the name of the default schema equality implementation in log mes…
martin-g Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion avro/src/schema_equality.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ pub fn set_schemata_equality_comparator(
pub(crate) fn compare_schemata(schema_one: &Schema, schema_two: &Schema) -> bool {
SCHEMATA_COMPARATOR_ONCE
.get_or_init(|| {
debug!("Going to use the default schemata equality comparator: SpecificationEq.",);
debug!("Going to use the default schemata equality comparator: StructFieldEq.",);
Box::new(StructFieldEq {
include_attributes: false,
})
Expand Down
10 changes: 10 additions & 0 deletions avro_derive/tests/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,6 +1389,9 @@ mod test_derive {

#[avro(default = r#""Foo""#)]
myenum: MyEnum,

#[avro(default = "null")]
optional: Option<String>,
}

let schema = r#"
Expand Down Expand Up @@ -1442,6 +1445,11 @@ mod test_derive {
"symbols":["Foo", "Bar", "Baz"]
},
"default":"Foo"
},
{
"name":"optional",
"type": ["null", "string"],
"default": null
}
]
}
Expand Down Expand Up @@ -1471,6 +1479,7 @@ mod test_derive {
),
"c" => assert_eq!(None, field.default),
"myenum" => assert_eq!(Some(json!("Foo")), field.default),
"optional" => assert_eq!(Some(json!(null)), field.default),
_ => panic!("Unexpected field name"),
}
}
Expand All @@ -1490,6 +1499,7 @@ mod test_derive {
.collect(),
array: vec![4, 5, 6],
myenum: MyEnum::Bar,
optional: None,
});
}

Expand Down