Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated TestRule in TestPipeline #30790

Closed

Conversation

scott-strong
Copy link
Contributor

addresses #30767

As the repository no longer supports junit 4 in favor of junit 5, the TestPipeline needed to be updated in order to remove the deprecated TestRule in favor of the extension interfaces BeforeEachCallback and AfterEachCallback. This essentially achieves the same purpose of running code before and after a test statement, but it then required some small tweaks to the code.

Note: I wasn't sure what error messages to use when checking for values that should almost always be set like the test method, test class, and current element.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Mar 28, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@scott-strong scott-strong marked this pull request as draft March 28, 2024 20:06
@myhau
Copy link

myhau commented Jun 24, 2024

Hello @scott-strong

I'm exploring the possibility of using JUnit 5 (instead of 4) to test Apache Beam pipelines (#18733).

Just curious, why was this closed?

@scott-strong
Copy link
Contributor Author

@myhau I think I had issues with some of the test pipelines, and I was able to fix my issue by including both junit4 and junit5 as dependencies in my repository (which is still not ideal).

I think the changes I made were valid, I just didn't feel strongly enough to continue pushing them through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants