[KafkaIO] Replace end offset consumer with admin client #36834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #36075, this PR removes support for old Kafka client libraries, requiring at least Kafka 2.8.2 or newer. Note that every version of Kafka <4.0.0 still supports API protocol versions <0.10.0 and the compatibility matrix indicates that versions of Kafka >=3.0.0 would provide the best compatibility in combination with versions of Kafka >=4.0.0.
I've got another change to the poll loop queued up that leverages features only available in versions of Kafka >=3.0.0, so I'll address that compatibility bit in a following PR.
This PR leverages the
Adminclient to request end offsets without creating buffers likeConsumerclients do. Profiling showed thatAdminclients used 10% of the memory that was used byConsumerclients for end offset requests. TheAdminclient returns aKafkaFuturefor every request which is fulfilled by an IO thread managed by the Kafka client library, thus restoring the background thread feature that was removed in #36075.I intend to backport this change to
KafkaUnboundedReaderin a separate PR.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.