Skip to content

Conversation

jillyan
Copy link

@jillyan jillyan commented Sep 4, 2025

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

github-actions bot commented Sep 4, 2025

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@Croway
Copy link
Contributor

Croway commented Sep 4, 2025

Hello @jillyan , thanks for the PR, I have two question:

  • Why are you targetting camel-4.8.x branch? can't you do this on main? (It will be easier for us to review and test)
  • Can you add a test that shows how this feature is supposed to be used?

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I like the idea, but as pointed by @Croway, this needs to go to the main branch.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this should go in main. We are not going to add new parameters on old branches.

@davsclaus davsclaus changed the base branch from camel-4.8.x to main September 16, 2025 18:11
@davsclaus davsclaus changed the base branch from main to camel-4.8.x September 16, 2025 18:11
@davsclaus
Copy link
Contributor

Are you going to change this to the main branch, as we only accept new work on the main branch.

If not then we will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants