- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.1k
 
CAMEL-16866: Add opentelemetry metrics component #19782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CAMEL-16866: Add opentelemetry metrics component #19782
Conversation
| 
           🌟 Thank you for your contribution to the Apache Camel project! 🌟 🤖 CI automation will test this PR automatically. 🐫 Apache Camel Committers, please review the following items: 
  | 
    
| 
           /component-test opentelemetry-metrics Result ❌ The tests failed please check the logs  | 
    
| 
           🤖 The Apache Camel test robot will run the tests for you 👍  | 
    
3b56635    to
    fda4045      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't have familiarity with the metrics generation but it seems fine. At some point in the future we may think how to group and abstract the metric to make it easier to evolve the group of concrete components organically.
        
          
                ...etry-metrics/src/main/java/org/apache/camel/opentelemetry/AbstractOpenTelemetryProducer.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                ...emetry-metrics/src/test/java/org/apache/camel/opentelemetry/CamelOpenTelemetryExtension.java
              
                Outdated
          
            Show resolved
            Hide resolved
        
      fda4045    to
    c7bb70b      
    Compare
  
    c7bb70b    to
    6c234b3      
    Compare
  
    | 
           /component-test opentelemetry-metrics Result ❌ The tests failed please check the logs  | 
    
| 
           🤖 The Apache Camel test robot will run the tests for you 👍  | 
    
| 
           Looks like the incremental tests fail on 'Docs': 
  | 
    
Description
Added an OpenTelemetry-Metrics Component that allows the addition of Timer, Counter, and Distribution-summary metric producers to routes.
Further PRs to add Camel RoutePolicy and EventNotifier metrics to follow.
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.