Skip to content

Conversation

@jonomorris
Copy link
Contributor

Description

Added an OpenTelemetry-Metrics Component that allows the addition of Timer, Counter, and Distribution-summary metric producers to routes.

Further PRs to add Camel RoutePolicy and EventNotifier metrics to follow.

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@jonomorris
Copy link
Contributor Author

squakez, optentelemetry metrics added as a new component as per you comment in #19766.

@jonomorris
Copy link
Contributor Author

jonomorris commented Nov 2, 2025

/component-test opentelemetry-metrics

Result ❌ The tests failed please check the logs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus davsclaus requested a review from squakez November 2, 2025 13:53
@davsclaus davsclaus force-pushed the CAMEL-16866_add_opentelemetry_component branch 2 times, most recently from 3b56635 to fda4045 Compare November 3, 2025 09:20
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't have familiarity with the metrics generation but it seems fine. At some point in the future we may think how to group and abstract the metric to make it easier to evolve the group of concrete components organically.

@davsclaus davsclaus force-pushed the CAMEL-16866_add_opentelemetry_component branch from fda4045 to c7bb70b Compare November 3, 2025 10:41
@davsclaus davsclaus force-pushed the CAMEL-16866_add_opentelemetry_component branch from c7bb70b to 6c234b3 Compare November 3, 2025 11:34
@jonomorris
Copy link
Contributor Author

jonomorris commented Nov 4, 2025

/component-test opentelemetry-metrics

Result ❌ The tests failed please check the logs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

🤖 The Apache Camel test robot will run the tests for you 👍

@jonomorris
Copy link
Contributor Author

Looks like the incremental tests fail on 'Docs':

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Camel :: Parent 4.16.0-SNAPSHOT:
[INFO] 
[INFO] Camel :: Parent .................................... SUCCESS [  1.347 s]
[INFO] Camel :: BOM ....................................... SUCCESS [  0.131 s]
[INFO] Camel :: Components ................................ SUCCESS [  3.115 s]
[INFO] Camel :: Main ...................................... SUCCESS [ 20.894 s]
[INFO] Camel :: Opentelemetry Metrics ..................... SUCCESS [ 11.373 s]
[INFO] Camel :: All Components Sync point ................. SUCCESS [  4.229 s]
[INFO] Camel :: Catalog :: Camel Catalog .................. SUCCESS [ 11.931 s]
[INFO] Camel :: Endpoint DSL .............................. SUCCESS [ 40.246 s]
[INFO] Camel :: Component DSL ............................. SKIPPED
[INFO] Camel :: Kamelet Main .............................. SUCCESS [  4.779 s]
[INFO] Camel :: Docs ...................................... FAILURE [ 22.201 s]
[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:yarn (yarn-gulp) on project docs: Failed to run task: 'yarn gulp' failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants