Virtual machine password handling in ConfigDrive #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
DaanHoogland
approved these changes
May 6, 2025
|
@phsm , your code change is based on 4.20, but the doc change here on main. Is that a problem? |
I am not sure. Shall I rebase the doc to 4.20 ? Or is it better to rebase this PR to main ? |
|
That depends on whether it is ready (and your preference @phsm ) |
phsm
force-pushed
the
4.20-configdrive-password-doc
branch
from
d3bb728 to
00a2eac
Compare
|
I've been told by someone of the maintainers in the past that I should create code PRs against the current stable branch, and not the main. So since the code PR is against 4.20, then it is better to rebase this PR to 4.20 too. I've rebased it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements the PR #10061 to Cloudstack, to explain how passwords are provided in ConfigDrive.
📚 Documentation preview 📚: https://cloudstack-documentation--501.org.readthedocs.build/en/501/