Skip to content

Conversation

abh1sar
Copy link
Contributor

@abh1sar abh1sar commented May 19, 2025

Documentation PR for apache/cloudstack#10856

ACL Lists

  1. Replace ACL Lists with ACLs as Access Control List Lists doesn't make sense
  2. Replace Add ACL with Add ACL rule wherever a rule is being added

User data

  1. Following industry conventions, User data should be written as two words
  2. The term "User Data" used in the main menu creates some confusion, whether it is singular or plural. So renamed it to "User Data Library" where users can register new User Data.
  3. User data should not be followed by "a"

📚 Documentation preview 📚: https://cloudstack-documentation--506.org.readthedocs.build/en/506/

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general remark; user data, User data and User Data seem to be used interchangably. maybe cleanup?
also I suggest a global replace of "ACL rule" with "access rule"

Comment on lines 318 to 319
About Network ACLs
^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
About Network ACLs
^^^^^^^^^^^^^^^^^^^^^^^
About Network ACLs
^^^^^^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 360 to 361
Creating ACLs
^^^^^^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creating ACLs
^^^^^^^^^^^^^^^^^^
Creating ACLs
^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 474 to 475
Creating a Tier with Custom ACL
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creating a Tier with Custom ACL
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Creating a Tier with Custom ACL
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 490 to 491
Assigning a Custom ACL to a Tier
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Assigning a Custom ACL to a Tier
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Assigning a Custom ACL to a Tier
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 125 to 126
Storing and accessing user data
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Storing and accessing user data
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Storing and accessing user data
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

:alt: Add IPv6 ACL rule.
.. |ipv6-acl-list.png| image:: /_static/images/ipv6-acl-list.png
:alt: IPv6 ACL rule in Network ACL list.
:alt: IPv6 ACL rule in Network ACL.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:alt: IPv6 ACL rule in Network ACL.
:alt: IPv6 access rule in Network ACL.

??

@abh1sar
Copy link
Contributor Author

abh1sar commented Jun 6, 2025

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/506. (QA-JID 358)

@abh1sar
Copy link
Contributor Author

abh1sar commented Jun 6, 2025

general remark; user data, User data and User Data seem to be used interchangably. maybe cleanup? also I suggest a global replace of "ACL rule" with "access rule"

Thanks for the review @DaanHoogland
I have cleaned up user data (there were also many instances where 'user-data' was being used. Have replaced it with 'user data'). Also, I had missed updating the screenshots earlier.

I’m not entirely convinced about using “access rule”. It feels like a more generic term and might be unclear without proper context. Other platforms, like AWS, use the term “ACL rules,” so I’d prefer to stick with that for clarity and consistency.
https://docs.aws.amazon.com/vpc/latest/userguide/nacl-rules.html


- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports.
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, Userdata, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks).
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, User data, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and Vpn. The supported services are Dns, Dhcp, User data, Firewall (for isolated networks) and Network ACL (for vpc and vpc networks).
- ROUTED. For isolated networks in ROUTED mode, the VR no longer supports Source NAT, Static NAT, Load Balancer, Port Forwarding and VPN. The supported services are DNS, DHCP, User data, Firewall (for isolated networks) and Network ACL (for VPC and VPC networks).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Network mode indicates the mode with which the isolated network or VPC will operate.
There are two valid options

- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, Vpn if the network offering supports.
- NATTED. This is the default network mode of isolated networks. The VR of isolated networks and VPCs provides Source NAT services, as well as Static NAT, Load Balancer, Port Forwarding, VPN if the network offering supports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

1:1 NAT Physical Physical and Virtual
Source NAT No Physical and Virtual
Userdata Yes Yes
User data Yes Yes
Copy link
Contributor

@sureshanaparti sureshanaparti Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
User data Yes Yes
User data Yes Yes

check column alignment with other columns text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@abh1sar
Copy link
Contributor Author

abh1sar commented Jun 18, 2025

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/506. (QA-JID 371)

@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Jul 21, 2025
@abh1sar abh1sar marked this pull request as ready for review July 28, 2025 13:04
@abh1sar
Copy link
Contributor Author

abh1sar commented Jul 28, 2025

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/506. (QA-JID 399)

Copy link

@rosi-shapeblue rosi-shapeblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The documentation has been updated in accordance with the scope defined in the FR.

@sureshanaparti sureshanaparti merged commit f285c3f into apache:4.20 Jul 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants