-
Notifications
You must be signed in to change notification settings - Fork 119
Add a note for JAVA_OPTS if using Java 17 for ACS versions >= 4.20.0 #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Pearl1594 , what is the path to this text from the docs? I can go to the location directly but don’t see how I’d reach this when going from “upgrading” or “release notes" |
I don't understand what you mean @DaanHoogland |
nobody will get to this text will they? When you go to the main page and than to upgrading, I do not see a path to this page anywhere. I.E. it is an orphaned page. |
Ah - you're right, I could reach it through: https://cloudstack-documentation--544.org.readthedocs.build/en/544/upgrading/upgrade/upgrade_notes.html . Let me add it and see if appears now. |
@blueorangutan docbuild |
@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/544. (QA-JID 409) |
@blueorangutan docbuild |
@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/544. (QA-JID 410) |
@DaanHoogland I've now added a separate page for java version details: https://qa.cloudstack.cloud/builds/docs-build/pr/544/upgrading/upgrade/upgrade_java_17_notes.html . Thanks for pointing it out. |
great @Pearl1594 , the page upgrade_notes is still never reached is it? I might be daft, but I have not found a way except for going to it directly through the navigation bar #security_by_obscurity |
https://github.com/apache/cloudstack-documentation/blob/main/source/upgrading/upgrade/_java_version.rst |
📚 Documentation preview 📚: https://cloudstack-documentation--544.org.readthedocs.build/en/544/