Skip to content

Add a note for JAVA_OPTS if using Java 17 for ACS versions >= 4.20.0 #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 4.20
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Aug 20, 2025

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland
Copy link
Contributor

@Pearl1594 , what is the path to this text from the docs? I can go to the location directly but don’t see how I’d reach this when going from “upgrading” or “release notes"

@Pearl1594
Copy link
Contributor Author

I don't understand what you mean @DaanHoogland

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Aug 20, 2025

nobody will get to this text will they? When you go to the main page and than to upgrading, I do not see a path to this page anywhere.

I.E. it is an orphaned page.

@Pearl1594
Copy link
Contributor Author

Ah - you're right, I could reach it through: https://cloudstack-documentation--544.org.readthedocs.build/en/544/upgrading/upgrade/upgrade_notes.html . Let me add it and see if appears now.

@Pearl1594
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/544. (QA-JID 409)

@Pearl1594
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/544. (QA-JID 410)

@Pearl1594
Copy link
Contributor Author

@DaanHoogland I've now added a separate page for java version details: https://qa.cloudstack.cloud/builds/docs-build/pr/544/upgrading/upgrade/upgrade_java_17_notes.html . Thanks for pointing it out.

@DaanHoogland
Copy link
Contributor

@DaanHoogland I've now added a separate page for java version details: https://qa.cloudstack.cloud/builds/docs-build/pr/544/upgrading/upgrade/upgrade_java_17_notes.html . Thanks for pointing it out.

great @Pearl1594 , the page upgrade_notes is still never reached is it? I might be daft, but I have not found a way except for going to it directly through the navigation bar #security_by_obscurity

@vishesh92
Copy link
Member

https://github.com/apache/cloudstack-documentation/blob/main/source/upgrading/upgrade/_java_version.rst
Should this file be updated instead of creating source/upgrading/upgrade/upgrade_java_17_notes.rst?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants