Skip to content

[VMware] Disk controller mappings #10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
winterhazel wants to merge 23 commits into
base: main
Choose a base branch
from

Add log

a0f9c55
Select commit
Loading
Failed to load commit list.
Open

[VMware] Disk controller mappings #10454

Add log
a0f9c55
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 15, 2025 in 0s

16.65% (+0.07%) compared to 8e4fe1c

View this Pull Request on Codecov

16.65% (+0.07%) compared to 8e4fe1c

Details

Codecov Report

Attention: Patch coverage is 62.92776% with 195 lines in your changes missing coverage. Please review.

Project coverage is 16.65%. Comparing base (8e4fe1c) to head (a0f9c55).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...he/cloudstack/storage/DiskControllerMappingVO.java 31.86% 61 Missing and 1 partial ⚠️
...oud/hypervisor/vmware/resource/VmwareResource.java 74.65% 31 Missing and 6 partials ⚠️
...m/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 78.46% 23 Missing and 5 partials ⚠️
...tack/storage/dao/DiskControllerMappingDaoImpl.java 0.00% 20 Missing ⚠️
...com/cloud/hypervisor/vmware/util/VmwareHelper.java 86.86% 13 Missing ⚠️
.../com/cloud/agent/api/SecStorageVMSetupCommand.java 0.00% 6 Missing ⚠️
...esource/VmwareSecondaryStorageResourceHandler.java 0.00% 6 Missing ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 6 Missing ⚠️
...cloud/storage/resource/VmwareStorageProcessor.java 0.00% 5 Missing ⚠️
.../secondarystorage/SecondaryStorageManagerImpl.java 0.00% 4 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10454      +/-   ##
============================================
+ Coverage     16.57%   16.65%   +0.07%     
- Complexity    13988    14081      +93     
============================================
  Files          5745     5747       +2     
  Lines        510847   510756      -91     
  Branches      62140    62049      -91     
============================================
+ Hits          84696    85053     +357     
+ Misses       416677   416219     -458     
- Partials       9474     9484      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov