server: generate password for VM created in stopped state #10720
Conversation
Fixes apache#10294 Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10720 +/- ##
============================================
- Coverage 15.17% 15.16% -0.01%
- Complexity 11332 11333 +1
============================================
Files 5415 5415
Lines 474893 474918 +25
Branches 57920 57927 +7
============================================
- Hits 72046 72042 -4
- Misses 394792 394821 +29
Partials 8055 8055
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13059 |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
| VMTemplateVO template = _templateDao.findById(userVm.getTemplateId()); | ||
| if (template != null && template.isEnablePassword()) { | ||
| String password = _mgr.generateRandomPassword(); | ||
| _vmDao.loadDetails(userVm); | ||
| userVm.setPassword(password); | ||
| encryptAndStorePassword(userVm, password); | ||
| } |
There was a problem hiding this comment.
this probably happens somewhere else as well. make a method?
There was a problem hiding this comment.
@DaanHoogland generate and store method are used differently in different place. A refactoring to consolidate can be done in a separate PR
|
[SF] Trillian test result (tid-13005)
|
Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13093 |
|
@shwstppr
the password in step 1 does not work, the password in the VR works
|
|
Thanks @weizhouapache for testing. Maybe the start VM code is not considering the stored password. Will check and update |
Description
Fixes #10294
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
stopped-vm-pass.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?