Fix logs mismatch between Network GC wait and interval #10776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10776 +/- ##
=========================================
Coverage 16.12% 16.12%
- Complexity 13210 13212 +2
=========================================
Files 5652 5652
Lines 496467 496468 +1
Branches 60120 60120
=========================================
+ Hits 80044 80071 +27
+ Misses 407515 407483 -32
- Partials 8908 8914 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql
Outdated
Show resolved
Hide resolved
nvazquez
reviewed
Apr 25, 2025
| logger.info("NetworkGarbageCollector uses '{}' seconds for GC interval.", netGcWait); | ||
| final int netGcInterval = NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60); | ||
| logger.info("NetworkGarbageCollector uses '{}' seconds for GC wait.", netGcWait); | ||
| logger.info("NetworkGarbageCollector uses '{}' seconds for GC interval.", netGcInterval); |
There was a problem hiding this comment.
Perhaps these 2 lines can be unified into a single one: NetworkGarbageCollector uses '{}' seconds for GC wait and '{}' seconds for GC interval.
engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql
Outdated
Show resolved
Hide resolved
Update dynamic setting for the network.gc.intervla and the wrong message for wait period.
network.gc.value was mistakenly obtained from network.gc.wait added messages for both gc.wait and gc.internval.
nvazquez
force-pushed
the
network-gc-wait-dynamic
branch
from
ee5c057 to
e0e9d64
Compare
nvazquez
changed the title
|
@blueorangutan package |
|
| @@ -3556,7 +3556,8 @@ public void reallyRun() { | |||
|
|
|||
| final List<Long> networkIds = _networksDao.findNetworksToGarbageCollect(); | |||
| final int netGcWait = NumbersUtil.parseInt(_configDao.getValue(NetworkGcWait.key()), 60); | |||
| logger.info("NetworkGarbageCollector uses '{}' seconds for GC interval.", netGcWait); | |||
| final int netGcInterval = NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60); | |||
There was a problem hiding this comment.
Is the purpose to only log it, why not use the ConfigKey read the value, than use the ConfigDao?
There was a problem hiding this comment.
Suggested change
| final int netGcInterval = NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60); | |
| final int netGcInterval = NumbersUtil.parseInt(NetworkGcInterval.value()), 60); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs:
2025-04-24 19:04:20,912 INFO [o.a.c.e.o.NetworkOrchestrator] (Network-Scavenger-1:ctx-34a60b9f) (logid:ab827a5e) NetworkGarbageCollector uses '121' seconds for GC interval.
^C
Actual values (with mgmt server restart done after the value changes):