-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Corrected quota type indexes #11085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Corrected quota type indexes #11085
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11085 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
Complexity 13968 13968
============================================
Files 5743 5743
Lines 510494 510494
Branches 62075 62075
============================================
- Hits 84617 84616 -1
Misses 416415 416415
- Partials 9462 9463 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@harikrishna-patnala thanks for the fix. I'll review and test it ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified that the types are mapped correctly now
@harikrishna-patnala should this be rebased to 4.20? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, manually tested in a local lab
121085a
to
1cb5512
Compare
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
done @DaanHoogland |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13926 |
@blueorangutan test keepEnv |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
This PR fixes #11082 with right indexes as the usage types
cloudstack/api/src/main/java/org/apache/cloudstack/usage/UsageTypes.java
Lines 47 to 50 in 01c721f
Types of changes
Bug Severity
How Has This Been Tested?
How did you try to break this feature and the system with this change?