Skip to content

Corrected quota type indexes #11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.20
Choose a base branch
from

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Jun 25, 2025

Description

This PR fixes #11082 with right indexes as the usage types

public static final int BACKUP = 28;
public static final int BUCKET = 29;
public static final int NETWORK = 30;
public static final int VPC = 31;

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (16c60c7) to head (121085a).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11085      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
  Complexity    13968    13968              
============================================
  Files          5743     5743              
  Lines        510494   510494              
  Branches      62075    62075              
============================================
- Hits          84617    84616       -1     
  Misses       416415   416415              
- Partials       9462     9463       +1     
Flag Coverage Δ
uitests 3.90% <ø> (ø)
unittests 17.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bernardodemarco bernardodemarco self-requested a review June 25, 2025 12:50
@bernardodemarco
Copy link
Collaborator

@harikrishna-patnala thanks for the fix. I'll review and test it ASAP

Copy link
Member

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified that the types are mapped correctly now

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Jun 25, 2025
@DaanHoogland
Copy link
Contributor

@harikrishna-patnala should this be rebased to 4.20?

Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, manually tested in a local lab

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@harikrishna-patnala harikrishna-patnala changed the base branch from main to 4.20 June 26, 2025 03:53
@harikrishna-patnala
Copy link
Contributor Author

harikrishna-patnala commented Jun 26, 2025

@harikrishna-patnala should this be rebased to 4.20?

done @DaanHoogland

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13926

@DaanHoogland
Copy link
Contributor

@blueorangutan test keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Incorrect quota type mappings to usage types
5 participants