server: remove extra chars when template status is error string

[shwstppr]

Description

Fixes #11324

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.17%. Comparing base (ca6d2dc) to head (81a12a6).
⚠️ Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...a/com/cloud/api/query/dao/TemplateJoinDaoImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #11329   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
- Complexity    11362    11363    +1     
=========================================
  Files          5415     5415           
  Lines        476030   476043   +13     
  Branches      58115    58116    +1     
=========================================
+ Hits          72246    72249    +3     
- Misses       395701   395710    +9     
- Partials       8083     8084    +1     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.90% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14438

[OlegChuev]

Hi @shwstppr. Maybe it would be cleaner to return state as failed and include the exact reason in the error_details? Wdyt?

[shwstppr]

@OlegChuev that can be a separate change. Adding a new response param with this behaviour would need change in UI too which relies on status field

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13965)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58832 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11329-t13965-kvm-ol8.zip
Smoke tests completed. 130 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_12_destroy_cpvm	Error	3.29	test_ssvm.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible	Error	1519.30	test_hostha_kvm.py

[weizhouapache]

code lgtm