Skip to content

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Jul 29, 2025

Description

This PR fixes the build error after merging 4.20 to main.

PR #9102 contains the change in RegisterUserDataCmd, which is restored in this PR.

Also added UI build fix. Contains changes from PR #10773

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@abh1sar abh1sar requested review from nvazquez and DaanHoogland July 29, 2025 17:32
@abh1sar abh1sar changed the title Fix build error in register user data cmd Fix build and ui build errors in main Jul 29, 2025
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.17%. Comparing base (2bffabb) to head (75a41b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11332      +/-   ##
============================================
- Coverage     18.15%   17.17%   -0.98%     
- Complexity    14991    14993       +2     
============================================
  Files          5433     5869     +436     
  Lines        486168   521715   +35547     
  Branches      57051    63503    +6452     
============================================
+ Hits          88257    89605    +1348     
- Misses       388000   422040   +34040     
- Partials       9911    10070     +159     
Flag Coverage Δ
uitests 3.76% <ø> (?)
unittests 18.15% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jul 29, 2025

looks like these are already fixed in main.

@abh1sar abh1sar closed this Jul 29, 2025
@abh1sar abh1sar reopened this Jul 29, 2025
@abh1sar
Copy link
Collaborator Author

abh1sar commented Jul 29, 2025

ui build is still failing in main

@sureshanaparti
Copy link
Contributor

@blueorangutan package

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abh1sar - LGTM

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

thanks @abh1sar , looks good. sorry for the merge chaos.

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11332 (QA-JID-701)

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14449

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14450

@nvazquez nvazquez merged commit da3ba17 into apache:main Jul 29, 2025
27 of 51 checks passed
@nvazquez nvazquez deleted the Fix-build-error-in-RegisterUserDataCmd branch July 29, 2025 20:02
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
* fix build error in registeruserdatacmd

* remove unused imports

* fix ui build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants