-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix build and ui build errors in main #11332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build and ui build errors in main #11332
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11332 +/- ##
============================================
- Coverage 18.15% 17.17% -0.98%
- Complexity 14991 14993 +2
============================================
Files 5433 5869 +436
Lines 486168 521715 +35547
Branches 57051 63503 +6452
============================================
+ Hits 88257 89605 +1348
- Misses 388000 422040 +34040
- Partials 9911 10070 +159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
looks like these are already fixed in main. |
ui build is still failing in main |
@blueorangutan package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abh1sar - LGTM
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
thanks @abh1sar , looks good. sorry for the merge chaos. |
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
UI build: ✔️ |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14449 |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14450 |
* fix build error in registeruserdatacmd * remove unused imports * fix ui build errors
Description
This PR fixes the build error after merging 4.20 to main.
PR #9102 contains the change in RegisterUserDataCmd, which is restored in this PR.
Also added UI build fix. Contains changes from PR #10773
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?