-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Prevent exceptions when network service provider that's disabled is viewed #11413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11413 +/- ##
============================================
- Coverage 17.35% 17.35% -0.01%
+ Complexity 15232 15230 -2
============================================
Files 5885 5885
Lines 525618 525632 +14
Branches 64157 64161 +4
============================================
- Hits 91225 91216 -9
- Misses 424094 424120 +26
+ Partials 10299 10296 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@Pearl1594 is this only applicable on main? |
@Pearl1594 can you check/fix this? |
@Pearl1594 With the changes, when I clicked on Nsx, Netris, Tungsten, nothing happens (old view remains as is), at least show message indicating the plugin is disabled, or hide all the disabled providers. |
The provider should appear disabled i.e., in red - which should be an indicator that it is disabled. As historically, we haven't explicitly prompted the user that a provider is disabled with any notification per se, which is why I continued with that behaviour. |
@@ -185,6 +199,18 @@ export default { | |||
} | |||
|
|||
try { | |||
const providers = ['tungsten', 'nsx', 'netris'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this list be retrieved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean from the backend? I don't believe so that we have a way (API) to identify external network providers.
I mean, we can get the list of all network service providers, but not what needs a global setting to be enabled to actually use it.
Description
This PR fixes these issues:

Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?