Skip to content

[WIP] Move console proxy related global settings to Zone level #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR moves console proxy related global settings to Zone level as CPVM in a zone level resource, and it makes sense to have these settings at the zone level

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 15.23810% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.41%. Comparing base (f020b5b) to head (b8c2c3b).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...om/cloud/consoleproxy/ConsoleProxyManagerImpl.java 0.00% 74 Missing ⚠️
...ud/consoleproxy/AgentBasedConsoleProxyManager.java 0.00% 6 Missing ⚠️
...ain/java/com/cloud/consoleproxy/AgentHookBase.java 0.00% 6 Missing ⚠️
...arystorage/PremiumSecondaryStorageManagerImpl.java 0.00% 2 Missing ⚠️
...udstack/consoleproxy/ConsoleAccessManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11415      +/-   ##
============================================
+ Coverage     17.35%   17.41%   +0.05%     
- Complexity    15230    15336     +106     
============================================
  Files          5885     5885              
  Lines        525626   527301    +1675     
  Branches      64160    64963     +803     
============================================
+ Hits          91217    91812     +595     
- Misses       424112   425162    +1050     
- Partials      10297    10327      +30     
Flag Coverage Δ
uitests 3.59% <ø> (-0.04%) ⬇️
unittests 18.45% <15.23%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Aug 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.2% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant