-
Notifications
You must be signed in to change notification settings - Fork 1.2k
server: enable KVM volume and VM snapshot by default #11446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
server: enable KVM volume and VM snapshot by default #11446
Conversation
Given EL6/EL7 is deprecated now and most modern supported KVM distros ship newer versions of qemu, KVM volume and VM snapshot can be enabled by default. Fixes apache#11445 Signed-off-by: Rohit Yadav <[email protected]>
@blueorangutan package |
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Signed-off-by: Rohit Yadav <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11446 +/- ##
=========================================
Coverage 17.36% 17.36%
+ Complexity 15236 15235 -1
=========================================
Files 5886 5886
Lines 525645 525645
Branches 64156 64156
=========================================
Hits 91257 91257
Misses 424093 424093
Partials 10295 10295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
Thanks for this change
@blueorangutan test keepEnv |
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-14062)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Given EL6/EL7 is deprecated now and most modern supported KVM distros ship newer versions of qemu, KVM volume and VM snapshot can be enabled by default.
Fixes #11445
Types of changes