ui: Allow edit source CIDR on load balancer rule

[CodeBleu]

Description

This PR allows editing the source CIDR of a load balancer rule.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Followed steps in ui/README.md

Ran on Cloudstack environment using the update cidr API fix (#11568) and confirmed access based on IP's added to source CIDR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.50%. Comparing base (d60f455) to head (0c962bf).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11766      +/-   ##
============================================
- Coverage     17.50%   17.50%   -0.01%     
  Complexity    15427    15427              
============================================
  Files          5894     5894              
  Lines        526847   526851       +4     
  Branches      64335    64337       +2     
============================================
- Hits          92234    92233       -1     
- Misses       424236   424241       +5     
  Partials      10377    10377              

Flag	Coverage Δ
uitests	3.61% <ø> (-0.01%)	⬇️
unittests	18.56% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[CodeBleu]

@blueorangutan ui

[blueorangutan]

@CodeBleu a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11766 (QA-JID-770)

[rohityadavcloud]

Didn't test this, but UI changes LGTM. I'm assuming this editing CIDR is available via API

[DaanHoogland]

@CodeBleu , I tested this in QA, but it silently fails, i.e. it reports success but does not change the cidr. Have a look at https://qa.cloudstack.cloud/client/pr/11766/#/publicip/e7314c68-c570-42c5-939e-e61f5b30cb4b

[CodeBleu]

@CodeBleu , I tested this in QA, but it silently fails, i.e. it reports success but does not change the cidr. Have a look at https://qa.cloudstack.cloud/client/pr/11766/#/publicip/e7314c68-c570-42c5-939e-e61f5b30cb4b

@DaanHoogland I believe this is because the QA build is not running the version needed to actually make the changes via the API.

#11766 (comment)

[DaanHoogland]

@CodeBleu , I tested this in QA, but it silently fails, i.e. it reports success but does not change the cidr. Have a look at https://qa.cloudstack.cloud/client/pr/11766/#/publicip/e7314c68-c570-42c5-939e-e61f5b30cb4b

@DaanHoogland I believe this is because the QA build is not running the version needed to actually make the changes via the API.

#11766 (comment)

ah, you might have a point, I’ll create a lab env.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[CodeBleu]

Didn't test this, but UI changes LGTM. I'm assuming this editing CIDR is available via API

Yes, this is the API code that was already merged #11568

[borisstoyanov]

@rosi-shapeblue can you help testing this, we'd like to include it in 4.22

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15325