refactor storepool automation

[DaanHoogland]

Description

This PR cleans up the StoragePoolAutomationImpl class to reduce its two big methods and reuse some code.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 151 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (36cfd76) to head (66d0ba5).
⚠️ Report is 7 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...a/com/cloud/storage/StoragePoolAutomationImpl.java	0.00%	151 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11789   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
  Complexity    13296    13296           
=========================================
  Files          5656     5656           
  Lines        498219   498239   +20     
  Branches      60451    60446    -5     
=========================================
+ Hits          80579    80584    +5     
- Misses       408672   408684   +12     
- Partials       8968     8971    +3     

Flag	Coverage Δ
uitests	4.00% <ø> (-0.01%)	⬇️
unittests	17.02% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15281

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14519)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11789-t14519-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_13_retrieve_vr_default_files	Error	1.11	test_diagnostics.py
test_14_retrieve_vr_one_file	Error	1.13	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	1.13	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.14	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	1.13	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.12	test_diagnostics.py

[blueorangutan]

[SF] Trillian test result (tid-14533)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 61853 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11789-t14533-kvm-ol8.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	Failure	5.24	test_diagnostics.py
test_13_retrieve_vr_default_files	Error	1.12	test_diagnostics.py
test_14_retrieve_vr_one_file	Error	1.14	test_diagnostics.py
test_15_retrieve_ssvm_default_files	Error	1.13	test_diagnostics.py
test_16_retrieve_ssvm_single_file	Error	1.12	test_diagnostics.py
test_17_retrieve_cpvm_default_files	Error	1.13	test_diagnostics.py
test_18_retrieve_cpvm_single_file	Error	1.16	test_diagnostics.py
test_05_create_template_with_no_checksum	Error	65.71	test_templates.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCRedundancy>:setup	Error	0.00	test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup	Error	0.00	test_vpc_router_nics.py