Skip to content

CLVM enhancements and fixes #12617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pearl1594 wants to merge 79 commits into
base: main
Choose a base branch
from

add clvm pools with deterministic uuid , so as to prevent adding the …

4b66876
Select commit
Loading
Failed to load commit list.
Draft

CLVM enhancements and fixes #12617

add clvm pools with deterministic uuid , so as to prevent adding the …
4b66876
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 28, 2026 in 4m 46s

Quality Gate failed

Failed conditions
1 Security Hotspot
32.9% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 260 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h9&open=AZ4Ig9a_LLXNfHHEi1h9&pullRequest=12617

Check warning on line 605 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hG&open=AZ4Ig9SkLLXNfHHEi1hG&pullRequest=12617

Check failure on line 227 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h6&open=AZ4Ig9a_LLXNfHHEi1h6&pullRequest=12617

Check warning on line 283 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_agentMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gP&open=AZ4Ig9DRLLXNfHHEi1gP&pullRequest=12617

Check warning on line 693 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9K5LLXNfHHEi1gZ&open=AZ4Ig9K5LLXNfHHEi1gZ&pullRequest=12617

Check failure on line 277 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig83DLLXNfHHEi1f1&open=AZ4Ig83DLLXNfHHEi1f1&pullRequest=12617

Check warning on line 884 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9K5LLXNfHHEi1gb&open=AZ4Ig9K5LLXNfHHEi1gb&pullRequest=12617

Check warning on line 2137 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ5mOf9VTZn6QeIQ70Y7&open=AZ5mOf9VTZn6QeIQ70Y7&pullRequest=12617

Check warning on line 2810 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "areBothPoolsClvmType" method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9hlLLXNfHHEi1i8&open=AZ4Ig9hlLLXNfHHEi1i8&pullRequest=12617

Check failure on line 1165 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to not always return the same value. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9XULLXNfHHEi1hi&open=AZ4Ig9XULLXNfHHEi1hi&pullRequest=12617

Check warning on line 368 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_volsDetailsDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9JYLLXNfHHEi1gW&open=AZ4Ig9JYLLXNfHHEi1gW&pullRequest=12617

Check warning on line 2152 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 79 to 64, Complexity from 21 to 14, Nesting Level from 5 to 2, Number of Variables from 25 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gV&open=AZ4Ig9DRLLXNfHHEi1gV&pullRequest=12617

Check warning on line 120 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig89MLLXNfHHEi1f-&open=AZ4Ig89MLLXNfHHEi1f-&pullRequest=12617

Check warning on line 7549 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "clustered" local variable. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9YwLLXNfHHEi1h1&open=AZ4Ig9YwLLXNfHHEi1h1&pullRequest=12617

Check warning on line 901 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hK&open=AZ4Ig9SkLLXNfHHEi1hK&pullRequest=12617

Check warning on line 111 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtClvmLockTransferCommandWrapper.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9NWLLXNfHHEi1gj&open=AZ4Ig9NWLLXNfHHEi1gj&pullRequest=12617

Check failure on line 282 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h_&open=AZ4Ig9a_LLXNfHHEi1h_&pullRequest=12617

Check failure on line 602 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1hF&open=AZ4Ig9SkLLXNfHHEi1hF&pullRequest=12617

Check warning on line 80 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the missing @Deprecated annotation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1iz&open=AZ4Ig9f_LLXNfHHEi1iz&pullRequest=12617

Check warning on line 54 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9f_LLXNfHHEi1iy&open=AZ4Ig9f_LLXNfHHEi1iy&pullRequest=12617

Check failure on line 196 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1h3&open=AZ4Ig9a_LLXNfHHEi1h3&pullRequest=12617

Check warning on line 280 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9DRLLXNfHHEi1gR&open=AZ4Ig9DRLLXNfHHEi1gR&pullRequest=12617

Check failure on line 238 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "qemu-img" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9SkLLXNfHHEi1g4&open=AZ4Ig9SkLLXNfHHEi1g4&pullRequest=12617

Check warning on line 2304 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig88pLLXNfHHEi1f7&open=AZ4Ig88pLLXNfHHEi1f7&pullRequest=12617

Check failure on line 314 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ4Ig9a_LLXNfHHEi1iC&open=AZ4Ig9a_LLXNfHHEi1iC&pullRequest=12617
View more details on SonarQubeCloud