Skip to content

Feature: Key Management Service (KMS) #12711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vishesh92 wants to merge 31 commits into
base: main
Choose a base branch
from

Fix failing unit tests

33f3d3d
Select commit
Loading
Failed to load commit list.
Draft

Feature: Key Management Service (KMS) #12711

Fix failing unit tests
33f3d3d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 1, 2026 in 1s

18.03% (+0.00%) compared to e2c13da

View this Pull Request on Codecov

18.03% (+0.00%) compared to e2c13da

Details

Codecov Report

❌ Patch coverage is 17.88800% with 2566 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.03%. Comparing base (e2c13da) to head (33f3d3d).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/apache/cloudstack/kms/KMSManagerImpl.java 34.63% 646 Missing and 22 partials ⚠️
...udstack/kms/provider/pkcs11/PKCS11HSMProvider.java 12.13% 414 Missing and 6 partials ⚠️
...e/cloudstack/kms/provider/DatabaseKMSProvider.java 0.00% 149 Missing ⚠️
...apache/cloudstack/api/response/KMSKeyResponse.java 0.00% 115 Missing ⚠️
.../kms/provider/database/KMSDatabaseKekObjectVO.java 0.00% 106 Missing ⚠️
.../main/java/org/apache/cloudstack/kms/KMSKeyVO.java 19.46% 91 Missing ⚠️
...n/java/org/apache/cloudstack/kms/HSMProfileVO.java 0.00% 76 Missing ⚠️
...ava/org/apache/cloudstack/kms/KMSWrappedKeyVO.java 11.53% 68 Missing and 1 partial ⚠️
...pache/cloudstack/kms/dao/KMSKekVersionDaoImpl.java 0.00% 50 Missing ⚠️
.../api/command/user/kms/hsm/CreateHSMProfileCmd.java 0.00% 49 Missing ⚠️
... and 38 more
Additional details and impacted files 
@@             Coverage Diff             @@
##               main   #12711     +/-   ##
===========================================
  Coverage     18.02%   18.03%             
- Complexity    16620    16723    +103     
===========================================
  Files          6029     6064     +35     
  Lines        542181   545705   +3524     
  Branches      66450    66753    +303     
===========================================
+ Hits          97737    98417    +680     
- Misses       433428   436234   +2806     
- Partials      11016    11054     +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov