Skip to content

Addition of description field for NIC's secondary IP addresses #12864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikbocks wants to merge 7 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'origin/main' into add-description-for-s…

9ed4bf9
Select commit
Loading
Failed to load commit list.
Open

Addition of description field for NIC's secondary IP addresses #12864

Merge remote-tracking branch 'origin/main' into add-description-for-s…
9ed4bf9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 1, 2026 in 0s

18.07% (-0.01%) compared to c45596c, passed because coverage increased by 0% when compared to adjusted base (18.07%)

View this Pull Request on Codecov

18.07% (-0.01%) compared to c45596c, passed because coverage increased by 0% when compared to adjusted base (18.07%)

Details

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.07%. Comparing base (c45596c) to head (9ed4bf9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/com/cloud/vm/dao/NicSecondaryIpVO.java 0.00% 8 Missing ⚠️
...loudstack/api/response/NicSecondaryIpResponse.java 0.00% 6 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 2 Missing ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java 0.00% 2 Missing ⚠️
...loudstack/api/command/user/vm/AddIpToVmNicCmd.java 0.00% 1 Missing ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12864      +/-   ##
============================================
- Coverage     18.07%   18.07%   -0.01%     
+ Complexity    16698    16697       -1     
============================================
  Files          6036     6036              
  Lines        542410   542429      +19     
  Branches      66424    66424              
============================================
- Hits          98051    98048       -3     
- Misses       433345   433366      +21     
- Partials      11014    11015       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov