backup: veeam kvm integration #12991
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| //Licensed to the Apache Software Foundation (ASF) under one | ||
| //or more contributor license agreements. See the NOTICE file | ||
| //distributed with this work for additional information | ||
| //regarding copyright ownership. The ASF licenses this file | ||
| //to you under the Apache License, Version 2.0 (the | ||
| //"License"); you may not use this file except in compliance | ||
| //the License. You may obtain a copy of the License at | ||
| // | ||
| //http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| //Unless required by applicable law or agreed to in writing, | ||
| //software distributed under the License is distributed on an | ||
| //"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| //KIND, either express or implied. See the License for the | ||
| //specific language governing permissions and limitations | ||
| //under the License. | ||
|
|
||
| package org.apache.cloudstack.api.command.admin.backup; | ||
|
|
||
| import javax.inject.Inject; | ||
|
|
||
| import org.apache.cloudstack.acl.RoleType; | ||
| import org.apache.cloudstack.api.APICommand; | ||
| import org.apache.cloudstack.api.ApiConstants; | ||
| import org.apache.cloudstack.api.BaseCmd; | ||
| import org.apache.cloudstack.api.Parameter; | ||
| import org.apache.cloudstack.api.command.admin.AdminCmd; | ||
| import org.apache.cloudstack.api.response.BackupResponse; | ||
| import org.apache.cloudstack.api.response.ImageTransferResponse; | ||
| import org.apache.cloudstack.api.response.VolumeResponse; | ||
| import org.apache.cloudstack.backup.ImageTransfer; | ||
| import org.apache.cloudstack.backup.KVMBackupExportService; | ||
| import org.apache.cloudstack.context.CallContext; | ||
|
|
||
| import com.cloud.utils.EnumUtils; | ||
|
|
||
| @APICommand(name = "createImageTransfer", | ||
| description = "Create image transfer for a disk in backup. This API is intended for testing only and is disabled by default.", | ||
|
Member
There was a problem hiding this comment.
this sentence exists in all APIs in this folder. is this correct ? @abh1sar
Contributor
There was a problem hiding this comment. yes Wei, I don't want to expose these APIs to end users. Only Veeam control service uses them. |
||
| responseObject = ImageTransferResponse.class, | ||
| since = "4.23.0", | ||
| authorized = {RoleType.Admin}) | ||
| public class CreateImageTransferCmd extends BaseCmd implements AdminCmd { | ||
|
|
||
| @Inject | ||
| private KVMBackupExportService kvmBackupExportService; | ||
|
|
||
| @Parameter(name = ApiConstants.BACKUP_ID, | ||
| type = CommandType.UUID, | ||
| entityType = BackupResponse.class, | ||
| description = "ID of the backup") | ||
| private Long backupId; | ||
|
|
||
| @Parameter(name = ApiConstants.VOLUME_ID, | ||
| type = CommandType.UUID, | ||
| entityType = VolumeResponse.class, | ||
| required = true, | ||
| description = "ID of the disk/volume") | ||
| private Long volumeId; | ||
|
|
||
| @Parameter(name = ApiConstants.DIRECTION, | ||
| type = CommandType.STRING, | ||
| required = true, | ||
| description = "Direction of the transfer: upload, download") | ||
| private String direction; | ||
|
|
||
| @Parameter(name = ApiConstants.FORMAT, | ||
| type = CommandType.STRING, | ||
| description = "Format of the image: cow/raw. Currently only raw is supported for download. Defaults to raw if not provided") | ||
|
Member
There was a problem hiding this comment.
I think the image is qcow2/cow format, right ?
Contributor
There was a problem hiding this comment. yes, the description is confusing. the format here is not the disk format, but the image transfer format. I'll update the description to |
||
| private String format; | ||
|
|
||
| public Long getBackupId() { | ||
| return backupId; | ||
| } | ||
|
|
||
| public Long getVolumeId() { | ||
| return volumeId; | ||
| } | ||
|
|
||
| public ImageTransfer.Direction getDirection() { | ||
| return ImageTransfer.Direction.valueOf(direction); | ||
| } | ||
|
|
||
| public ImageTransfer.Format getFormat() { | ||
| return EnumUtils.getEnum(ImageTransfer.Format.class, format); | ||
| } | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| ImageTransferResponse response = kvmBackupExportService.createImageTransfer(this); | ||
| response.setObjectName(ImageTransfer.class.getSimpleName().toLowerCase()); | ||
| response.setResponseName(getCommandName()); | ||
| setResponseObject(response); | ||
| } | ||
|
|
||
| @Override | ||
| public long getEntityOwnerId() { | ||
| return CallContext.current().getCallingAccount().getId(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| //Licensed to the Apache Software Foundation (ASF) under one | ||
| //or more contributor license agreements. See the NOTICE file | ||
| //distributed with this work for additional information | ||
| //regarding copyright ownership. The ASF licenses this file | ||
| //to you under the Apache License, Version 2.0 (the | ||
| //"License"); you may not use this file except in compliance | ||
| //the License. You may obtain a copy of the License at | ||
| // | ||
| //http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| //Unless required by applicable law or agreed to in writing, | ||
| //software distributed under the License is distributed on an | ||
| //"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| //KIND, either express or implied. See the License for the | ||
| //specific language governing permissions and limitations | ||
| //under the License. | ||
|
|
||
| package org.apache.cloudstack.api.command.admin.backup; | ||
|
|
||
| import javax.inject.Inject; | ||
|
|
||
| import org.apache.cloudstack.acl.RoleType; | ||
| import org.apache.cloudstack.api.APICommand; | ||
| import org.apache.cloudstack.api.ApiConstants; | ||
| import org.apache.cloudstack.api.BaseCmd; | ||
| import org.apache.cloudstack.api.Parameter; | ||
| import org.apache.cloudstack.api.command.admin.AdminCmd; | ||
| import org.apache.cloudstack.api.response.SuccessResponse; | ||
| import org.apache.cloudstack.api.response.UserVmResponse; | ||
| import org.apache.cloudstack.backup.KVMBackupExportService; | ||
| import org.apache.cloudstack.context.CallContext; | ||
|
|
||
| @APICommand(name = "deleteVirtualMachineCheckpoint", | ||
| description = "Delete a VM checkpoint. This API is intended for testing only and is disabled by default.", | ||
| responseObject = SuccessResponse.class, | ||
| since = "4.23.0", | ||
| authorized = {RoleType.Admin}) | ||
| public class DeleteVmCheckpointCmd extends BaseCmd implements AdminCmd { | ||
|
|
||
| @Inject | ||
| private KVMBackupExportService kvmBackupExportService; | ||
|
|
||
| @Parameter(name = ApiConstants.VIRTUAL_MACHINE_ID, | ||
| type = CommandType.UUID, | ||
| entityType = UserVmResponse.class, | ||
| required = true, | ||
| description = "ID of the VM") | ||
| private Long vmId; | ||
|
|
||
| @Parameter(name = "checkpointid", | ||
| type = CommandType.STRING, | ||
| required = true, | ||
| description = "Checkpoint ID") | ||
| private String checkpointId; | ||
|
|
||
| public Long getVmId() { | ||
| return vmId; | ||
| } | ||
|
|
||
| public String getCheckpointId() { | ||
| return checkpointId; | ||
| } | ||
|
|
||
| public void setVmId(Long vmId) { | ||
| this.vmId = vmId; | ||
| } | ||
|
|
||
| public void setCheckpointId(String checkpointId) { | ||
| this.checkpointId = checkpointId; | ||
| } | ||
|
|
||
| @Override | ||
| public void execute() { | ||
| boolean result = kvmBackupExportService.deleteVmCheckpoint(this); | ||
| SuccessResponse response = new SuccessResponse(getCommandName()); | ||
| response.setSuccess(result); | ||
| response.setResponseName(getCommandName()); | ||
| setResponseObject(response); | ||
| } | ||
|
|
||
| @Override | ||
| public long getEntityOwnerId() { | ||
| return CallContext.current().getCallingAccount().getId(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwstppr
is
/etc/cloudstack/agent/cloud.ca.crtused ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abh1sar can tell better but I think yes we use cloud certificates for image server.
To the Veeam worker VM, we just pass the Root CA from the MS
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's right. Is it ok to show the file names?