KVM Host HA code improvements

[sureshanaparti]

Description

This PR improves the Host HA code (updates logs and some refactoring / cleanup).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[codecov]

Codecov Report

❌ Patch coverage is 10.68376% with 209 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.68%. Comparing base (ffebe8e) to head (c3f6d76).

Files with missing lines	Patch %	Lines
...ache/cloudstack/kvm/ha/KVMHostActivityChecker.java	0.00%	78 Missing ⚠️
...java/com/cloud/ha/HighAvailabilityManagerImpl.java	9.09%	40 Missing ⚠️
...vm/src/main/java/com/cloud/ha/KVMInvestigator.java	0.00%	16 Missing ⚠️
...oud/hypervisor/kvm/storage/LibvirtStoragePool.java	0.00%	16 Missing ⚠️
...java/org/apache/cloudstack/kvm/ha/KVMHAConfig.java	0.00%	10 Missing ⚠️
...om/cloud/hypervisor/kvm/resource/KVMHAMonitor.java	0.00%	9 Missing ⚠️
...oud/hypervisor/kvm/storage/LinstorStoragePool.java	0.00%	7 Missing ⚠️
...ud/hypervisor/kvm/storage/StorPoolStoragePool.java	0.00%	5 Missing ⚠️
...urce/wrapper/LibvirtCheckOnHostCommandWrapper.java	42.85%	3 Missing and 1 partial ⚠️
...om/cloud/hypervisor/kvm/resource/KVMHAChecker.java	72.72%	2 Missing and 1 partial ⚠️
... and 13 more

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #13088   +/-   ##
=========================================
  Coverage     17.67%   17.68%           
- Complexity    15789    15791    +2     
=========================================
  Files          5922     5922           
  Lines        533094   533086    -8     
  Branches      65210    65201    -9     
=========================================
+ Hits          94246    94255    +9     
+ Misses       428208   428190   -18     
- Partials      10640    10641    +1     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.75% <10.68%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17658

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests