Skip to content

Multiple CD-ROM / ISO Support Per VM #13101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Damans227 wants to merge 35 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'upstream/main' into fr283-multi-cdrom

68ac686
Select commit
Loading
Failed to load commit list.
Draft

Multiple CD-ROM / ISO Support Per VM #13101

Merge remote-tracking branch 'upstream/main' into fr283-multi-cdrom
68ac686
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 17, 2026 in 0s

18.10% (+0.01%) compared to 5893ba5

View this Pull Request on Codecov

18.10% (+0.01%) compared to 5893ba5

Details

Codecov Report

❌ Patch coverage is 41.28440% with 192 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.10%. Comparing base (5893ba5) to head (68ac686).

Files with missing lines Patch % Lines
...n/java/com/cloud/template/TemplateManagerImpl.java 39.54% 92 Missing and 15 partials ⚠️
...rc/main/java/com/cloud/vm/dao/VmIsoMapDaoImpl.java 0.00% 44 Missing ⚠️
...ava/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 51.28% 13 Missing and 6 partials ⚠️
...apache/cloudstack/api/response/UserVmResponse.java 33.33% 8 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 7 Missing ⚠️
.../schema/src/main/java/com/cloud/vm/VmIsoMapVO.java 83.33% 3 Missing and 1 partial ⚠️
.../cloudstack/api/command/user/iso/DetachIsoCmd.java 0.00% 1 Missing ⚠️
...e/cloudstack/api/response/AttachedIsoResponse.java 95.23% 0 Missing and 1 partial ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13101      +/-   ##
============================================
+ Coverage     18.09%   18.10%   +0.01%     
- Complexity    16723    16770      +47     
============================================
  Files          6037     6041       +4     
  Lines        542580   542928     +348     
  Branches      66427    66489      +62     
============================================
+ Hits          98155    98307     +152     
- Misses       433399   433570     +171     
- Partials      11026    11051      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov