Skip to content

Clarify KVM import template requirement#13126

Open
andrijapanicsb wants to merge 1 commit into
mainfrom
fix/clarify-kvm-import-templateid-requirement
Open

Clarify KVM import template requirement#13126
andrijapanicsb wants to merge 1 commit into
mainfrom
fix/clarify-kvm-import-templateid-requirement

Conversation

@andrijapanicsb
Copy link
Copy Markdown
Contributor

@andrijapanicsb andrijapanicsb commented May 7, 2026

Description

importUnmanagedInstance documents templateid as an optional parameter, but KVM unmanaged instance import currently requires a template and fails when one is not supplied.

This updates the generated API parameter description for templateid to explicitly mention that it is required when importing an unmanaged KVM instance. It avoids the current mismatch between API docs and runtime behavior without changing import semantics.

Fixes #13067

Tests

Added ImportUnmanagedInstanceCmdTest coverage to verify the templateid API parameter description includes the KVM requirement.





##########################################################
Generated by AI - do you REALLY think I became a Java developer overnight?
So, REVIEW PROPERLY and feel free to decline the PR if it's bunch of junk !
#########################################################

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.09%. Comparing base (f6efda5) to head (3de13b0).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13126   +/-   ##
=========================================
  Coverage     18.09%   18.09%           
- Complexity    16721    16723    +2     
=========================================
  Files          6037     6037           
  Lines        542546   542546           
  Branches      66431    66431           
=========================================
+ Hits          98159    98170   +11     
+ Misses       433368   433355   -13     
- Partials      11019    11021    +2     
Flag Coverage Δ
uitests 3.52% <ø> (ø)
unittests 19.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@andrijapanicsb
Copy link
Copy Markdown
Contributor Author

@blueorangutan package kvm

@blueorangutan
Copy link
Copy Markdown

@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled withkvm SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17772

@andrijapanicsb
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@andrijapanicsb
Copy link
Copy Markdown
Contributor Author

@blueorangutan test ol8 kvm-ol8 keepEnv

@blueorangutan
Copy link
Copy Markdown

@andrijapanicsb a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-16103)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 80792 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13126-t16103-kvm-ol8.zip
Smoke tests completed. 146 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_vm_backup_create_vm_from_backup Failure 607.89 test_backup_recovery_nas.py
test_vm_backup_lifecycle Error 0.11 test_backup_recovery_nas.py
ContextSuite context=TestSharedFSLifecycle>:setup Error 0.00 test_sharedfs_lifecycle.py
test_10_attachAndDetach_iso Failure 607.19 test_vm_life_cycle.py
test_01_create_vm_snapshots Failure 606.85 test_vm_snapshots.py
test_02_revert_vm_snapshots Failure 600.71 test_vm_snapshots.py
test_03_delete_vm_snapshots Failure 0.02 test_vm_snapshots.py
test_01_create_volume Failure 611.47 test_volumes.py
test_01_root_volume_encryption Failure 696.11 test_volumes.py
test_02_data_volume_encryption Failure 637.86 test_volumes.py
test_03_root_and_data_volume_encryption Failure 659.05 test_volumes.py
test_02_attach_volume Failure 1267.43 test_volumes.py
test_02_attach_volume Failure 1267.45 test_volumes.py
test_03_download_attached_volume Failure 663.81 test_volumes.py
test_04_delete_attached_volume Failure 666.64 test_volumes.py
test_05_detach_volume Failure 751.52 test_volumes.py
test_06_download_detached_volume Failure 844.95 test_volumes.py
test_07_resize_fail Failure 658.48 test_volumes.py
test_08_resize_volume Failure 664.01 test_volumes.py
test_09_delete_detached_volume Failure 661.88 test_volumes.py
test_10_list_volumes Failure 658.37 test_volumes.py
test_11_attach_volume_with_unstarted_vm Failure 761.39 test_volumes.py
test_12_resize_volume_with_only_size_parameter Failure 663.91 test_volumes.py
test_13_migrate_volume_and_change_offering Failure 793.20 test_volumes.py
test_14_delete_volume_delete_protection Failure 666.96 test_volumes.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optional templateid param fails for KVM VM import

2 participants