[VFS-856] Fix JunctionTests #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,6 +141,9 @@ public void testEvent() throws Exception { | |||
| final FileObject real2 = baseDir.resolveFile("weakref.txt"); | |||
| real2.createFile(); | |||
| assertEquals("Weak Listener was abandoned", "Listener false true false", listener2.toString()); | |||
|
|
|||
| // Make sure we don't contaminate the fs for the next time the test runs | |||
| assertTrue(file2.delete()); | |||
There was a problem hiding this comment.
Hi @raboof
If you want this to happen 100% of the time, as opposed to not if an assertion fails, you must put it in a finally block.
The test would leave a file behind, causing it to fail the next time it runs (e.g. impacting 'mvn install')
raboof
force-pushed
the
fix-JunctionTests
branch
from
06b44d2 to
c859b39
Compare
|
TY @raboof ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test would leave a file behind, causing it to fail the next time it runs (e.g. impacting 'mvn install')
mvn; that'smvnon the command line by itself.