-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temp: Cordova-Android 14 & SDK 35 Test PR #1745
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 23 23
Lines 1854 1854
=======================================
Hits 1333 1333
Misses 521 521 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The PR updates the version to 8.7.2 🤔 What about the kotlin version? should we update to 2.x? |
It seems I was using an RC version of Android Studio at the time that used AGP 8.7.0-rc01 as default. I’ve noticed a newer version and upgraded to the stable 8.7.2 but forgot to update the commit message, leading to incorrect information in the PR description. Since 8.7.2 is the current default, I’ll correct the commit message and update the PR description.
The latest official release of Android Studio is still using |
Kotlin 2 is considered beta for IDE users, so Android Studio might not behave as expected when using K2. https://kotlinlang.org/docs/releases.html#release-details So it might be better to stay on 1.x for now. |
Just a heads up that the Android release cycle has changed for the first time in a long time. We already have 16 in Beta (we would have expected it in June of 2025), and is expected to be released as early as Q2 (rather than Q3). We’ll want to target 36 earlier than expected. |
What we have right now are the developer previews, which is more like an alpha. The betas are only scheduled to come out in Q1. https://developer.android.com/about/versions/16 Final releases tends to land in August and I don't think their timeline is any different than what we normally see. |
Sorry, I should have said Alpha. But recall that the first Android 15 beta was in April, and we’re now seeing that 16 will likely be in January. I agree, there’s not a lot of clarity on the final release date, but it looks like it could be as early as May, likewise 3 months earlier than the expected August. |
Could be, they never really give an explicit final release date. But historically the final releases if I recall were around or slightly before August. At the end of August they'll also bump the required target SDK for new apps. In November they will require all app updates to target a newer SDK. At least that is what Google has done in previous years. Currently they require SDK 34. So they will require API 35 for new apps most likely starting at the end of August. And their current timeline fits that schedule. |
Next major release will be in Q2 and a minor release in Q4. So next release will be somewhere in between April and June; but if I had to guess, it will be in May. |
In the end what matters to us is not when is released but when is required in google play and google has not made an announcement about when SDK 35 will be required, much less about SDK 36. Of course the sooner we release the better for the users. |
93c2ecf
to
d9f256a
Compare
8b31dab
to
d799375
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed feelings on the removal of generic types when calling constructors but still requiring the <>
, it seems like super awkward syntax but I guess that's just how Java works.
I like how the lambdas clean up callback functions, but it might be nice to keep the parameter types for readability?
New Android Studio projects set the |
yeah, gradle is printing warnings about having the compatibility value set to 8, so bumping it to 11 would be good |
I think it should be bumped as well. |
Thank you for your help. My name is Hiroshi Homma and I work as an Android engineer in Japan. Regarding this PR, when do you expect it to be merged? For my work, I am planning to update to Target SDK 35 using Cordova, and I would like to let you know when it will be completed. |
Support for SDK 35 has already been added to the main branch. This PR was temporary for collecting SDK 35 changes and testing. The only remaining changes in this PR are refactoring updates, which will not be in the next release. |
@erisu Since it's already fixed, if I update cordova-android to version 13 in the project, will the target SDK become 35?
Sorry for asking another question. |
SDK 35 support will be released in It is currently in the voting process. Voting process takes a minimum of 48 hours to complete, but maybe longer depending on the voting results. If the voting process is successful it maybe released some time between March 25th and 26th, but the exact ETA can’t be confirmed. |
@erisu Webkit got a realeasde of 1.13 stable. To late to bump this one? |
Yes, it's too late. But the version is configurable, that's just the default version, you can set the desired version with |
Motivation and Context
Prepare for Cordova-Android 14 Release & Android SDK 35 support.
Description
Note: This PR is intended to collect changes for testing and will be split into smaller PRs later.
General Changes for Next Major:
SDK 35 Support Changes:
Other changes from this PR:
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)