refactor!: Replace p libs with native JS APIs#197
Conversation
7141eb4 to
62d7e6a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
===========================================
+ Coverage 59.15% 82.92% +23.77%
===========================================
Files 5 5
Lines 71 82 +11
===========================================
+ Hits 42 68 +26
+ Misses 29 14 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
erisu
left a comment
There was a problem hiding this comment.
Overall, it LGTM.
If you can figure out a way to avoid using rewire, that would be even better. Since there are only two test files, I was hoping we could eventually drop rewire and Jasmine in favor of Node's built-in test framework, but that could also be revisited in a separate PR.
Probably could be done but I'll try it in a separate PR and I'll create an issue for myself to serve as a reminder. |
Platforms affected
CLI
Motivation and Context
Modernizing the codebase to remove third-party dependencies
Description
Marked as a breaking change due to the introduction of async syntax. Current engines should be already a satisfied based on these new requirements.
62d7e6a is a missed artifact from #175
I included as its own commit in this PR for simplicity but if necessary I can split it into its own PR.
Testing
Ran npm test
Checklist
(platform)if this change only applies to one platform (e.g.(android))