Skip to content

fix(chttpd): Always show browser login popup #5369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chttpd): Always show browser login popup #5369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/chttpd/src/chttpd.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1235,13 +1235,17 @@ error_headers(#httpd{mochi_req = MochiReq} = Req, 401 = Code, ErrorStr, ReasonSt
undefined ->
{Code, []};
AuthRedirect ->
case
RequireValidUser =
chttpd_util:get_chttpd_config_boolean(
"require_valid_user", false
)
of
) orelse
chttpd_util:get_chttpd_config_boolean(
"require_valid_user_except_for_up", false
),
case RequireValidUser of
true ->
% send the browser popup header no matter what if we are require_valid_user
% send the browser popup header no matter what
% if we are require_valid_user or require_valid_user_except_up
{Code, [{"WWW-Authenticate", "Basic realm=\"server\""}]};
false ->
case
Expand Down