Skip to content

updatted github action by change version tag to sha hashes #15315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −13
Draft

updatted github action by change version tag to sha hashes #15315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62c8ca5
updatted github action by change version tag to sha hashes
Jiashu-Hu Mar 19, 2025
f5f6efa
Merge branch 'apache:main' into Improve/GithubActions
Jiashu-Hu Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/actions/setup-macos-aarch64-builder/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
# under the License.

name: Prepare Rust Builder for MacOS
description: 'Prepare Rust Build Environment for MacOS'
description: "Prepare Rust Build Environment for MacOS"
inputs:
rust-version:
description: 'version of rust to install (e.g. stable)'
description: "version of rust to install (e.g. stable)"
required: true
default: 'stable'
default: "stable"
runs:
using: "composite"
steps:
Expand All @@ -44,6 +44,6 @@ runs:
rustup default stable
rustup component add rustfmt
- name: Setup rust cache
uses: Swatinem/rust-cache@v2
uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6
- name: Configure rust runtime env
uses: ./.github/actions/setup-rust-runtime
uses: ./.github/actions/setup-rust-runtime
7 changes: 3 additions & 4 deletions .github/actions/setup-rust-runtime/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,22 @@
# under the License.

name: Setup Rust Runtime
description: 'Setup Rust Runtime Environment'
description: "Setup Rust Runtime Environment"
runs:
using: "composite"
steps:
- name: Run sccache-cache
uses: mozilla-actions/sccache-action@v0.0.4
uses: mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd
- name: Configure runtime env
shell: bash
# do not produce debug symbols to keep memory usage down
# hardcoding other profile params to avoid profile override values
# More on Cargo profiles https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
#
#
# Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build
# See for more details: https://github.com/rust-lang/rust/issues/119560
run: |
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -C incremental=false was introduced in #8730, but I'm pretty sure it should actually be disabled with an env variable instead:

echo "CARGO_INCREMENTAL=0" >> $GITHUB_ENV

The RUSTCFLAGS incremental only specifies the "path to a directory where incremental files will be stored" — so in this case it is requesting to store incremental files in the folder named "false".

Since sccache does not cache incremental files, using the env var instead of the flag should have some good improvements on the sccache hit rate.


2 changes: 1 addition & 1 deletion .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
name: Check License Header
steps:
- uses: actions/checkout@v4
- uses: korandoru/hawkeye@v6
- uses: korandoru/hawkeye@dd74178a96f27b1121447c6b4a4ccfce180d5bf7

prettier:
name: Use prettier to check formatting of documents
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
name: Check License Header
steps:
- uses: actions/checkout@v4
- uses: korandoru/hawkeye@v6
- uses: korandoru/hawkeye@dd74178a96f27b1121447c6b4a4ccfce180d5bf7

# Check crate compiles and base cargo check passes
linux-build-lib:
Expand Down Expand Up @@ -153,7 +153,6 @@ jobs:
- name: Check datafusion-proto (avro)
run: cargo check --profile ci --no-default-features -p datafusion-proto --features=avro


# Check datafusion crate features
#
# Ensure via `cargo check` that the crate can be built with a
Expand Down Expand Up @@ -324,7 +323,6 @@ jobs:
if: ${{ !cancelled() }}
run: docker logs minio-container


linux-test-example:
name: cargo examples (amd64)
needs: linux-build-lib
Expand Down
Loading