Skip to content

docs: Clarify that it is only the name of the field that is ignored #16052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 14, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Clarify that the name is ignored, not the field

Are these changes tested?

Are there any user-facing changes?

@alamb alamb added the documentation Improvements or additions to documentation label May 14, 2025
@github-actions github-actions bot added logical-expr Logical plan and expressions and removed documentation Improvements or additions to documentation labels May 14, 2025
@kylebarron
Copy link
Contributor

Is the nullability of the field taken into account?

@alamb
Copy link
Contributor Author

alamb commented May 14, 2025

Is the nullability of the field taken into account?

It is for some cases (like make_array I believe)

@alamb alamb changed the title fix: Clarify that it is only the name of the field that is ignored docs: Clarify that it is only the name of the field that is ignored May 15, 2025
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb alamb merged commit 2f67a7e into apache:main May 15, 2025
29 checks passed
@alamb
Copy link
Contributor Author

alamb commented May 15, 2025

Thank you for the review @comphead and the catch @kylebarron

brayanjuls pushed a commit to brayanjuls/arrow-datafusion that referenced this pull request May 16, 2025
jfahne pushed a commit to jfahne/datafusion that referenced this pull request May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants