-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Semver-checks for all crate on merge and push #16078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
logan-keede
wants to merge
8
commits into
apache:main
Choose a base branch
from
logan-keede:semver_ci_clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
655a056
review ready
logan-keede bd3d218
Tweak rust setup for datafusion
logan-keede 16e4690
Tweak rust setup to avoid overloading disk space
logan-keede ed30167
Tweak semver-check setup to avoid overloading disk space 2
logan-keede 90d68a0
Add substrait back
logan-keede 5566125
disk space management
logan-keede 074453d
Merge branch 'main' into semver_ci_clean
logan-keede 98ad8dd
Merge branch 'main' into semver_ci_clean
logan-keede File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
name: API Changes | ||
|
||
concurrency: | ||
group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} | ||
cancel-in-progress: true | ||
|
||
on: | ||
push: | ||
paths-ignore: | ||
- "docs/**" | ||
- "**.md" | ||
- ".github/ISSUE_TEMPLATE/**" | ||
- ".github/pull_request_template.md" | ||
pull_request: | ||
paths-ignore: | ||
- "docs/**" | ||
- "**.md" | ||
- ".github/ISSUE_TEMPLATE/**" | ||
- ".github/pull_request_template.md" | ||
|
||
jobs: | ||
semver-checks: | ||
runs-on: ubuntu-latest | ||
continue-on-error: true | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Install semver-checks | ||
run: cargo install cargo-semver-checks --locked | ||
- name: Run semver-check datasource | ||
run: cargo semver-checks check-release -p datafusion-datasource -p datafusion-datasource-avro -p datafusion-datasource-csv -p datafusion-datasource-json -p datafusion-datasource-parquet | ||
continue-on-error: true | ||
- name: Run semver-check common | ||
run: cargo semver-checks check-release -p datafusion-common -p datafusion-common-runtime | ||
continue-on-error: true | ||
- name: Run semver-check catalog | ||
run: cargo semver-checks check-release -p datafusion-catalog -p datafusion-catalog-listing | ||
continue-on-error: true | ||
- name: Run semver-check execution | ||
run: cargo semver-checks check-release -p datafusion-execution -p datafusion-session | ||
continue-on-error: true | ||
- name: Run semver-check expr | ||
run: cargo semver-checks check-release -p datafusion-expr -p datafusion-expr-common -p datafusion-physical-expr | ||
continue-on-error: true | ||
- name : Run semver-check functions | ||
run: cargo semver-checks check-release -p datafusion-functions -p datafusion-functions-aggregate -p datafusion-functions-aggregate-common -p datafusion-functions-nested -p datafusion-functions-table -p datafusion-functions-window -p datafusion-functions-window-common | ||
continue-on-error: true | ||
|
||
|
||
semver-checks-2: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why are there multiple jobs? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because a single job runs out of disk space. |
||
runs-on: ubuntu-latest | ||
continue-on-error: true | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Install semver-checks | ||
run: cargo install cargo-semver-checks --locked | ||
- name: Run semver-check proto | ||
run: cargo semver-checks check-release -p datafusion-proto -p datafusion-proto-common | ||
continue-on-error: true | ||
- name: Run semver-check substrait #not working for some reason, TB Triaged | ||
run: apt-get install -y cmake && cargo semver-checks check-release -p datafusion-substrait | ||
continue-on-error: true | ||
- name: Run semver-check sql | ||
run: cargo semver-checks check-release -p datafusion-sql | ||
continue-on-error: true | ||
|
||
semver-checks-3: | ||
runs-on: ubuntu-latest | ||
continue-on-error: true | ||
container: | ||
image: amd64/rust | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup Rust toolchain | ||
uses: ./.github/actions/setup-builder | ||
with: | ||
rust-version: stable | ||
- name: Install semver-checks | ||
run: cargo install cargo-semver-checks --locked | ||
- name: Run semver-check datafusion-cli | ||
run: cargo semver-checks check-release -p datafusion-cli | ||
continue-on-error: true | ||
- name: Run semver-check datafusion | ||
run: cargo semver-checks check-release -p datafusion | ||
continue-on-error: true | ||
- name: Run semver-check macros | ||
run: cargo semver-checks check-release -p datafusion-macros | ||
continue-on-error: true | ||
- name: Run semver-check optimizer | ||
run: cargo semver-checks check-release -p datafusion-optimizer -p datafusion-physical-optimizer | ||
continue-on-error: true | ||
- name: Run semver-check physical-plan | ||
run: cargo semver-checks check-release -p datafusion-physical-plan | ||
continue-on-error: true | ||
- name: Run semver-check spark | ||
run: cargo semver-checks check-release -p datafusion-spark | ||
continue-on-error: true | ||
- name: Run semver-check sqllogictest | ||
run: cargo semver-checks check-release -p datafusion-sqllogictest | ||
continue-on-error: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can somehow automate this listing? Otherwise we will likely never update this list when we add new crates.