Update documentation for datafusion.execution.collect_statistics
#16100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xudong963
reviewed
May 19, 2025
| @@ -292,7 +292,9 @@ config_namespace! { | |||
| /// target batch size is determined by the configuration setting | |||
| pub coalesce_batches: bool, default = true | |||
|
|
|||
| /// Should DataFusion collect statistics after listing files | |||
| /// Should DataFusion collect statistics when first creating a table. | |||
There was a problem hiding this comment.
Thank you @alamb
This doc will definitely help a lot!!! (I also have been confused for many times)
xudong963
approved these changes
May 19, 2025
github-actions
bot
added
sqllogictest
|
This should fix CI: |
leoyvens
reviewed
May 19, 2025
findepi
approved these changes
May 20, 2025
|
Thank @leoyvens @xudong963 and @findepi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I have gotten confused several times that the
collect_statisticssetting only applies when first creating a ListingTable (it doesn't affect queries afterwards). Let's make this clearer in the documentationWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
Only documentation